You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/09/16 11:34:56 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #42957: [WIP][SQL] Update error messages related to parameterized `sql()`
MaxGekk opened a new pull request, #42957:
URL: https://github.com/apache/spark/pull/42957
### What changes were proposed in this pull request?
TODO
### Why are the changes needed?
TODO
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the affected test suite:
```
$ build/sbt "core/testOnly *SparkThrowableSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #42957:
URL: https://github.com/apache/spark/pull/42957#issuecomment-1724472819
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`
URL: https://github.com/apache/spark/pull/42957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #42957:
URL: https://github.com/apache/spark/pull/42957#discussion_r1328617632
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1892,7 +1892,7 @@
},
"INVALID_SQL_ARG" : {
"message" : [
- "The argument <name> of `sql()` is invalid. Consider to replace it by a SQL literal."
+ "The argument <name> of `sql()` is invalid. Consider to replace it either by a SQL literal or by a map constructed by `map()`, `map_from_arrays()`, `map_from_entries()`, or by an array constructed by `array()`. Also such functions can be invoked via `call_function()`."
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42957: [SPARK-45188][SQL][DOCS] Update error messages related to parameterized `sql()`
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42957:
URL: https://github.com/apache/spark/pull/42957#discussion_r1328222789
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1892,7 +1892,7 @@
},
"INVALID_SQL_ARG" : {
"message" : [
- "The argument <name> of `sql()` is invalid. Consider to replace it by a SQL literal."
+ "The argument <name> of `sql()` is invalid. Consider to replace it either by a SQL literal or by a map constructed by `map()`, `map_from_arrays()`, `map_from_entries()`, or by an array constructed by `array()`. Also such functions can be invoked via `call_function()`."
Review Comment:
maybe just say `collection constructor functions such as map(), array(), struct()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org