Re: [PR] gitSync: add extraEnvFrom to git-sync containers to support proxy settings from k8s secret [airflow]

["rasulkarimov (via GitHub)" <gi...@apache.org>]

rasulkarimov commented on code in PR #39031:
URL: https://github.com/apache/airflow/pull/39031#discussion_r1665173215


##########
chart/templates/_helpers.yaml:
##########
@@ -198,6 +198,7 @@ If release name contains chart name it will be used as a full name.
   image: {{ template "git_sync_image" . }}
   imagePullPolicy: {{ .Values.images.gitSync.pullPolicy }}
   securityContext: {{- include "localContainerSecurityContext" .Values.dags.gitSync | nindent 4 }}
+  envFrom: {{- include "custom_airflow_environment_from" . | default "\n  []" | indent 2 }}

Review Comment:
   Defined separate variable for gitSync envFrom - dags.gitSync.envFrom 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org