You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/27 17:20:38 UTC
[GitHub] [arrow-rs] nevi-me opened a new pull request #234: [Parquet] Read list field correctly
nevi-me opened a new pull request #234:
URL: https://github.com/apache/arrow-rs/pull/234
# Which issue does this PR close?
Closes #167 .
# Rationale for this change
We have been creating incorrect list types when reading Parquet lists to Arrow. If we have a list with field type:
```rust
let list_field = Field::new("a", DataType::List(Box::new(Field::new("item", DataType::_, true))), true);
```
We would instead read this list in as
```rust
let list_field = Field::new("a", DataType::List(Box::new(Field::new("a", DataType::_, true))), true);
```
With the list child taking the list's name of `"a"`.
# What changes are included in this PR?
This PR fixes the above issue.
it also fixes the order of the `LevelInfo` that's generated, as I identified this issue while fixing the test case for the above issue.
# Are there any user-facing changes?
No user changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #234: Read list field correctly
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #234:
URL: https://github.com/apache/arrow-rs/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #234: [Parquet] Read list field correctly
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #234:
URL: https://github.com/apache/arrow-rs/pull/234#issuecomment-827784195
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2018f43) into [master](https://codecov.io/gh/apache/arrow-rs/commit/111d5d67c76500b14aece28b3cbf145c4400f7fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (111d5d6) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 82.49% 82.51% +0.02%
==========================================
Files 162 162
Lines 43621 43655 +34
==========================================
+ Hits 35983 36022 +39
+ Misses 7638 7633 -5
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyLnJz) | `77.14% <100.00%> (+0.57%)` | :arrow_up: |
| [parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyLnJz) | `98.32% <100.00%> (+0.09%)` | :arrow_up: |
| [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `85.71% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [111d5d6...2018f43](https://codecov.io/gh/apache/arrow-rs/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org