You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "innovark37 (via GitHub)" <gi...@apache.org> on 2025/10/20 14:30:14 UTC
[PR] fix(Select): fix Russian translations for Select [superset]
innovark37 opened a new pull request, #35751:
URL: https://github.com/apache/superset/pull/35751
### SUMMARY
Strings `Select all` and `Deselect all` are not extracted from `Select` component when following the [documentation](https://superset.apache.org/docs/contributing/howtos/#extracting-new-strings-for-translation). This PR fixes missing translations for Select component.
FYI: `Deselect all` is translated only because `ListView` component uses this string.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE**
<img width="254" height="441" alt="image" src="https://github.com/user-attachments/assets/6acae06d-6967-4f7b-a20a-59dbb378345c" />
**AFTER**
<img width="246" height="465" alt="image" src="https://github.com/user-attachments/assets/0d620412-7a81-4484-8c93-f078fbaf3ed5" />
### TESTING INSTRUCTIONS
1. Add next lines to config file:
```
BABEL_DEFAULT_LOCALE` = "ru"
LANGUAGES = {
"ru": {"flag": "ru", "name": "Русский"},
"en": {"flag": "us", "name": "English"}
}
```
2. Start the application.
3. Create dashboard.
4. Add native filter (Filter type = "Value").
5. Verify the translations in Select footer (strings `Select all` and `Deselect all`).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2555725716
##########
superset-frontend/packages/superset-ui-core/src/components/Select/styles.tsx:
##########
@@ -142,5 +142,6 @@ export const StyledBulkActionsContainer = styled(Flex)`
${({ theme }) => `
padding: ${theme.sizeUnit}px;
border-top: 1px solid ${theme.colorSplit};
+ flex-wrap: wrap;
Review Comment:
I can suggest to remove this string here and move `wrap` style to `StyledBulkActionsContainer` tag:
```
<StyledBulkActionsContainer` justify="center" wrap>
...
</StyledBulkActionsContainer>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-3422363515
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/35751?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 50.73%. Comparing base ([`0b3fe3d`](https://app.codecov.io/gh/apache/superset/commit/0b3fe3d60ccbb5d80370af3baafcd74879d34de6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8846250`](https://app.codecov.io/gh/apache/superset/commit/8846250e7f03d25d671ef3d47eb475a3f8f915c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #35751 +/- ##
===========================================
+ Coverage 0 50.73% +50.73%
===========================================
Files 0 589 +589
Lines 0 43635 +43635
Branches 0 4725 +4725
===========================================
+ Hits 0 22137 +22137
- Misses 0 20874 +20874
- Partials 0 624 +624
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/35751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/35751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.27% <ø> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/35751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.98% <ø> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/35751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.72% <ø> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/35751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/35751?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4328597087
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4328359429
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 43216f4ffd0043636c5b490d035fe9ed47db5883 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69ef836c8a3f0700097ee8ff |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-35751--superset-docs-preview.netlify.app](https://deploy-preview-35751--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-35751--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4421497984
I wonder why that sharded Jest tests (6) keeps getting cancelled. I picked a random other frontend PR, #40000, and it succeeded in 6m:
> [Frontend Build CI (unit tests, linting & sanity checks) / sharded-jest-tests (6) (pull_request)](https://github.com/apache/superset/actions/runs/25634367918/job/75243706941?pr=40000)Successful in 6m
I would love to be 100% sure that the small changes to this one frontend file aren't causing a problem with that CI test. I will merge master in again and force the re-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4441034330
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2449717473
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -533,6 +556,10 @@ msgstr "2/98 процентиль"
msgid "22"
msgstr "22"
+#, fuzzy
+msgid "24 hours"
+msgstr "6 часов"
Review Comment:
should this be 24 instead of 6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2449716978
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -497,6 +516,10 @@ msgstr "104 недели"
msgid "104 weeks ago"
msgstr "104 недели назад"
+#, fuzzy
+msgid "12 hours"
+msgstr "1 час"
Review Comment:
should this be 12 instead of 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2642741275
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -504,7 +504,7 @@ const Select = forwardRef(
handleSelectAll();
}}
>
- {`${t('Select all')} (${bulkSelectCounts.selectable})`}
+ {t('Select all')} {`(${bulkSelectCounts.selectable})`}
Review Comment:
There is no need in plural form for translation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2642731443
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -504,7 +504,7 @@ const Select = forwardRef(
handleSelectAll();
}}
>
- {`${t('Select all')} (${bulkSelectCounts.selectable})`}
+ {t('Select all')} {`(${bulkSelectCounts.selectable})`}
Review Comment:
**Suggestion:** Internationalization bug: the button text is built by concatenating a translated string and a separately rendered count, which prevents translators from reordering words or handling pluralization/grammar in other languages (e.g., Russian). Replace the concatenation with a single translation call that accepts the count as an argument so translators can provide a correct localized sentence or plural form. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
{t('Select all (%s)', bulkSelectCounts.selectable)}
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a legitimate i18n concern — concatenating a translated string and a raw count forces a specific word order and prevents translators from handling grammar/plurals properly. Replacing with a single translation call that accepts the count (or a proper pluralization key) fixes that. The code in the PR contains exactly the concatenation, so the suggestion is applicable and improves localization correctness.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
**Line:** 507:507
**Comment:**
*Logic Error: Internationalization bug: the button text is built by concatenating a translated string and a separately rendered count, which prevents translators from reordering words or handling pluralization/grammar in other languages (e.g., Russian). Replace the concatenation with a single translation call that accepts the count as an argument so translators can provide a correct localized sentence or plural form.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-3686329656
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-3686116864
## Nitpicks 🔍
<table>
<tr><td>🔒 <strong>No security issues identified</strong></td></tr>
<tr><td>⚡ <strong>Recommended areas for review</strong><br><br>
- [ ] <a href='https://github.com/apache/superset/pull/35751/files#diff-35372e3b3930efdf4a7f714a90a1e818b7964572bd3279892623269d69737172R495-R525'><strong>Accessibility</strong></a><br>The new buttons render the count inline but do not expose an explicit aria-label that includes the dynamic count. Screen reader users may not get the full context (action + number). Verify the buttons are announced correctly and consider providing aria-labels that include the count or an aria-live region for updates.<br>
- [ ] <a href='https://github.com/apache/superset/pull/35751/files#diff-35372e3b3930efdf4a7f714a90a1e818b7964572bd3279892623269d69737172R493-R526'><strong>i18n / pluralization</strong></a><br>The change separates the static label from the dynamic count (e.g. {t('Select all')} {`(${bulkSelectCounts.selectable})`}). While this enables extraction of the base strings, it may break correct word order or pluralization rules in languages such as Russian where the count's placement and inflection matter. Consider using a single localized message with a placeholder or pluralization support so translators can place the count appropriately.<br>
- [ ] <a href='https://github.com/apache/superset/pull/35751/files#diff-35372e3b3930efdf4a7f714a90a1e818b7964572bd3279892623269d69737172R495-R499'><strong>Layout change</strong></a><br>The bulk actions container gained the `wrap` prop (StyledBulkActionsContainer justify="center" wrap). Confirm that the styled component supports the `wrap` prop and that the visual change does not negatively affect compact layouts or overflow in small viewports.<br>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-3686111544
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4038292373
## **Sequence Diagram**
This PR ensures the Select component's bulk actions use properly extracted Russian translations for the Select all and Clear labels while updating selected values and notifying parent components.
```mermaid
sequenceDiagram
participant User
participant SelectComponent as Select component
participant I18n as Translation service
participant Parent as Parent component
User->>SelectComponent: Open dropdown with bulk actions
SelectComponent->>I18n: Request text for Select all and Clear
I18n-->>SelectComponent: Return localized labels
User->>SelectComponent: Click Select all
SelectComponent->>SelectComponent: Compute new selected values
SelectComponent->>Parent: Fire onChange with updated values
User->>SelectComponent: Click Clear
SelectComponent->>SelectComponent: Remove deselectable values
SelectComponent->>Parent: Fire onChange with cleared values
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2449714441
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -304,6 +312,10 @@ msgstr "Агрегатных функций: %s"
msgid "%s column(s)"
msgstr "Столбцов: %s"
+#, fuzzy, python-format
+msgid "%s item(s)"
+msgstr "Нет фильтров"
Review Comment:
Did we lose the fuzzy search number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4391740368
Hi @innovark37 sorry this has languished! I just merged a large Russian language update this morning: https://github.com/apache/superset/pull/39589 Could you merge the latest master into this PR? Then let's see if we can get this merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #35751:
URL: https://github.com/apache/superset/pull/35751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2543214609
##########
superset-frontend/packages/superset-ui-core/src/components/Select/styles.tsx:
##########
@@ -142,5 +142,6 @@ export const StyledBulkActionsContainer = styled(Flex)`
${({ theme }) => `
padding: ${theme.sizeUnit}px;
border-top: 1px solid ${theme.colorSplit};
+ flex-wrap: wrap;
Review Comment:
Is there a better way without using this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2477268429
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -497,6 +516,10 @@ msgstr "104 недели"
msgid "104 weeks ago"
msgstr "104 недели назад"
+#, fuzzy
+msgid "12 hours"
+msgstr "1 час"
Review Comment:
It was fixed in #35750
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -533,6 +556,10 @@ msgstr "2/98 процентиль"
msgid "22"
msgstr "22"
+#, fuzzy
+msgid "24 hours"
+msgstr "6 часов"
Review Comment:
It was fixed in #35750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4038360410
@sadpandajoe @SBIN2010
Hi! This PR is still open and I'd love to move it forward. If there are any concerns or changes needed, please let me know and I'll be happy to address them. Thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2477267314
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -304,6 +312,10 @@ msgstr "Агрегатных функций: %s"
msgid "%s column(s)"
msgstr "Столбцов: %s"
+#, fuzzy, python-format
+msgid "%s item(s)"
+msgstr "Нет фильтров"
Review Comment:
It was fixed in #35750
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -483,6 +498,10 @@ msgstr "Годовая частота (начало года)"
msgid "10 minute"
msgstr "10 минут"
+#, fuzzy
+msgid "10 seconds"
+msgstr "30 секунд"
Review Comment:
It was fixed in #35750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-3686117728
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2449716029
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -483,6 +498,10 @@ msgstr "Годовая частота (начало года)"
msgid "10 minute"
msgstr "10 минут"
+#, fuzzy
+msgid "10 seconds"
+msgstr "30 секунд"
Review Comment:
should this be 10 instead of 30?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Select): fix Russian translations for Select [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #35751:
URL: https://github.com/apache/superset/pull/35751#issuecomment-4433230751
Well that was dumb, I had to re-merge master branch 4 times until CI passed? Seems flaky to me but I'll take it. Thanks @innovark37 for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org