You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2008/11/17 22:28:44 UTC
[jira] Created: (GERONIMO-4415) monitoring console code needs
improvement
monitoring console code needs improvement
-----------------------------------------
Key: GERONIMO-4415
URL: https://issues.apache.org/jira/browse/GERONIMO-4415
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: monitoring
Affects Versions: 2.2
Reporter: David Jencks
Assignee: David Jencks
Fix For: 2.2
The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4415) monitoring console code needs
improvement
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648358#action_12648358 ]
David Jencks commented on GERONIMO-4415:
----------------------------------------
Some initial work in rev 718393. I also added a little test server for convenience, build with -Pit to include it.
> monitoring console code needs improvement
> -----------------------------------------
>
> Key: GERONIMO-4415
> URL: https://issues.apache.org/jira/browse/GERONIMO-4415
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
>
> The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
> Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4415) monitoring console code needs
improvement
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653222#action_12653222 ]
David Jencks commented on GERONIMO-4415:
----------------------------------------
Use new feature from GERONIMO-4445 to provide a "private" security realm for the default subject used to call the MEJB. Since we aren't using the system/manager identity for calling the MEJB we shouldn't run into any problems changing this user.
> monitoring console code needs improvement
> -----------------------------------------
>
> Key: GERONIMO-4415
> URL: https://issues.apache.org/jira/browse/GERONIMO-4415
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
>
> The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
> Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4415) monitoring console code needs
improvement
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651200#action_12651200 ]
David Jencks commented on GERONIMO-4415:
----------------------------------------
Trygve Harderson noticed that the use of a SimpleCredentialStore for the subject used by the ejb timer so the timeout can access MEJB means that if you change the system/manager password you also have to update the credential store.
The obvious way to fix this is to create a new realm solely for the use of this credential store that generates a subject with only the mejb-user principal.
> monitoring console code needs improvement
> -----------------------------------------
>
> Key: GERONIMO-4415
> URL: https://issues.apache.org/jira/browse/GERONIMO-4415
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
>
> The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
> Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4415) monitoring console code needs
improvement
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4415.
----------------------------------
Resolution: Fixed
I don't anticipate any more code cleanup for 2.2, however desirable it might be.
> monitoring console code needs improvement
> -----------------------------------------
>
> Key: GERONIMO-4415
> URL: https://issues.apache.org/jira/browse/GERONIMO-4415
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
>
> The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
> Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4415) monitoring console code needs
improvement
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652364#action_12652364 ]
Donald Woods commented on GERONIMO-4415:
----------------------------------------
We need to resolve this before we release 2.2, as we want users to change the default system pwd.
> monitoring console code needs improvement
> -----------------------------------------
>
> Key: GERONIMO-4415
> URL: https://issues.apache.org/jira/browse/GERONIMO-4415
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
>
> The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.
> Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.