You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cclauss <gi...@git.apache.org> on 2018/08/16 23:08:38 UTC
[GitHub] spark pull request #22128: Add test_slice() to streaming BasicOperations
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22128
Add test_slice() to streaming BasicOperations
As suggested in https://github.com/apache/spark/pull/20838#pullrequestreview-139118618
## What changes were proposed in this pull request?
Add a test for slice operations on streams.
(Please fill in changes proposed in this fix)
## How was this patch tested?
It is a new test being added to the automated test suite.
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cclauss/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22128
----
commit 4094422d58077aa95129a7ec9fddf75c2e3af7a7
Author: cclauss <cc...@...>
Date: 2018-08-16T23:06:59Z
Add test_slice() to streaming BasicOperations
As suggested in https://github.com/apache/spark/pull/20838#pullrequestreview-139118618
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22128: Add test_slice() to streaming BasicOperations
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22128
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22128: Add test_slice() to streaming BasicOperations
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/22128
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22128: Add test_slice() to streaming BasicOperations
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22128
I think that comment suggested to add `flake8` in the testing framework. Let's better fix these in the same PR and leave this closed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22128: Add test_slice() to streaming BasicOperations
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22128
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22128: Add test_slice() to streaming BasicOperations
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22128
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org