You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by laozhp <gi...@git.apache.org> on 2016/02/26 06:31:12 UTC
[GitHub] thrift pull request: set reconn_time's default value to 0
GitHub user laozhp opened a pull request:
https://github.com/apache/thrift/pull/895
set reconn_time's default value to 0
When first time reconnect without a success call, line 214: Backoff = 2 * R, will cause exception, because R is undefined. Set reconn_time's default value to 0 resolved this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laozhp/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/895.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #895
----
commit cfa255940affb0d8901a7f31f8873dbfdb5a8213
Author: laozhp <la...@gmail.com>
Date: 2016-02-26T05:30:16Z
set reconn_time's default value to 0
When first time reconnect without a success call, line 214: Backoff = 2 * R, will cause exception, because R is undefined. Set reconn_time's default value to 0 resolved this.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3689] thrift_reconnecting_client star...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/895#issuecomment-189770638
@laozhp, it indeed is a problem and the fix looks good.
Merging shortly after, thanks again !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3689] thrift_reconnecting_client star...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/895
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3689] thrift_reconnecting_client star...
Posted by laozhp <gi...@git.apache.org>.
Github user laozhp commented on the pull request:
https://github.com/apache/thrift/pull/895#issuecomment-189755980
@nsuke OK, I have created an issue just now, [THRIFT-3689] thrift_reconnecting_client start failed when server is not available
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: set reconn_time's default value to 0
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/895#issuecomment-189604311
@laozhp thanks for the fix ! Could you create an issue in our JIRA ?
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---