[GitHub] [helix] junkaixue commented on a diff in pull request #2107: Add TTL and Container modes to BaseDataAccessor and its implementations

[GitBox <gi...@apache.org>]

junkaixue commented on code in PR #2107:
URL: https://github.com/apache/helix/pull/2107#discussion_r878555050


##########
helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java:
##########
@@ -43,6 +43,18 @@
    */
   boolean create(String path, T record, int options);
 
+  /**
+   * This will always attempt to create the znode, if it exists it will return false. Will
+   * create parents if they do not exist. For performance reasons, it may try to create
+   * child first and only if it fails it will try to create parents
+   * @param path path to the ZNode to create
+   * @param record the data to write to the ZNode
+   * @param options Set the type of ZNode see the valid values in {@link AccessOption}
+   * @param ttl TTL of the node in milliseconds, if options supports it
+   * @return true if creation succeeded, false otherwise (e.g. if the ZNode exists)
+   */
+  boolean create(String path, T record, int options, long ttl);

Review Comment:
   So this only applies to create? It means this property cannot be added in the middle by override or set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org