You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/16 11:09:45 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #65: Add github PR check to make sure code is formatted
mdedetrich opened a new pull request, #65:
URL: https://github.com/apache/incubator-pekko-http/pull/65
Adds a github PR status check which disallows PR's from being merged if the code is not formatted. Note that its been verified that this works in another pekko module (see https://github.com/apache/incubator-pekko-sbt-paradox/blob/main/.asf.yaml#L28-L35)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #65: Add github PR check to make sure code is formatted
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #65:
URL: https://github.com/apache/incubator-pekko-http/pull/65#issuecomment-1432928170
> We should also add "Checks" and "Compile and test (2.13, 1.8)".
Same response as https://github.com/apache/incubator-pekko/pull/199#issuecomment-1432922427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #65: Add github PR check to make sure code is formatted
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #65:
URL: https://github.com/apache/incubator-pekko-http/pull/65#issuecomment-1432923597
We should also add "Checks" and "Compile and test (2.13, 1.8)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #65: Add github PR check to make sure code is formatted
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #65:
URL: https://github.com/apache/incubator-pekko-http/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org