You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crail.apache.org by Adrian Schuepbach <DR...@zurich.ibm.com> on 2019/06/11 08:05:41 UTC
Close PR right on Github page
Hi Julian
It seems that I do not have the right to close (or merge) a PR. The
button just does not appear for me. I thought that when I linked my GitHub
account with my Apache ID I got the rights, but now I don't have them.
Might those rights have been lost after migrating to gitbox?
I am still able to merge changes via the command line. But it would
be great, if I could also close (or merge) PRs on the website.
What should I do to get these rights again?
Thanks
Adrian
Re: Re: Close PR right on Github page
Posted by Felix Cheung <fe...@hotmail.com>.
Great!
________________________________
From: Adrian Schuepbach <DR...@zurich.ibm.com>
Sent: Thursday, June 13, 2019 5:33:04 AM
To: dev@crail.apache.org
Subject: Re: Re: Close PR right on Github page
Hi Felix
Thanks a lot! It seem that I only linked the Apache ID with my account and
joined the Apache group, but did not follow the rest of the steps (I did
this before
migrating to gitbox).
I have done the steps now and wait until it is all synchronized and
assume/hope it will work then.
Thanks a lot, this was a very useful hint!
Adrian
From: "Felix Cheung" <fe...@hotmail.com>
To: "dev@crail.apache.org" <de...@crail.apache.org>
Date: 06/13/2019 03:28 AM
Subject: [EXTERNAL] Re: Close PR right on Github page
Adrian, did you link your account? You should be able to close or merge PR
once you have setup.
https://urldefense.proofpoint.com/v2/url?u=https-3A__gitbox.apache.org_setup_&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=pcxZvCQyESWay4DCuwO7dXLiJ4NahPw6YN0LJ8XEt6k&m=5OAdnPdjB7MWuNmwpl8rTeTgnssXSiZBDAdqBVIXN3Y&s=w_sdA4b0XbpDJEovGRfNhSfrLlIRAmwE56belivrBQU&e=
________________________________
From: Adrian Schüpbach <ad...@gribex.net>
Sent: Tuesday, June 11, 2019 2:41:54 PM
To: dev@crail.apache.org
Subject: Re: Close PR right on Github page
Hi Julian
Thanks for your answer. Right, "Close #nnn" has worked for me,
in some cases I'd prefer that a PR, which we really can not accept,
does not even create a history, so a commit with "Close #nnn"
would not be the right approach in those cases.
I will ask INFRA how to set permissions. Since some of us
have the "Close" button on the GitHUB UI, it must be
possible somehow to configure this.
Thanks
Adrian
On 11.06.2019 19:48, Julian Hyde wrote:
> I suspect that closing a PR from the Github UI may be possible now we
have gitbox, if permissions are set correctly. But I don’t know how to set
permissions. You could try asking INFRA in hipchat.
>
> The method I use isn’t pretty but it has worked for a long time. Add a
comment ‘Close #nnn’ or ‘Closes #nnn’ or ‘Close
apache/incubator-crail#nnn’ on its own line in a commit message. When the
commit is merged into master the bot will close the PR.
>
> Julian
>
>
>> On Jun 11, 2019, at 1:05 AM, Adrian Schuepbach <DR...@zurich.ibm.com>
wrote:
>>
>> Hi Julian
>>
>> It seems that I do not have the right to close (or merge) a PR. The
>> button just does not appear for me. I thought that when I linked my
GitHub
>> account with my Apache ID I got the rights, but now I don't have them.
>>
>> Might those rights have been lost after migrating to gitbox?
>>
>> I am still able to merge changes via the command line. But it would
>> be great, if I could also close (or merge) PRs on the website.
>>
>> What should I do to get these rights again?
>>
>> Thanks
>> Adrian
>>
>>
>
Re: Re: Close PR right on Github page
Posted by Adrian Schuepbach <DR...@zurich.ibm.com>.
Hi Felix
Thanks a lot! It seem that I only linked the Apache ID with my account and
joined the Apache group, but did not follow the rest of the steps (I did
this before
migrating to gitbox).
I have done the steps now and wait until it is all synchronized and
assume/hope it will work then.
Thanks a lot, this was a very useful hint!
Adrian
From: "Felix Cheung" <fe...@hotmail.com>
To: "dev@crail.apache.org" <de...@crail.apache.org>
Date: 06/13/2019 03:28 AM
Subject: [EXTERNAL] Re: Close PR right on Github page
Adrian, did you link your account? You should be able to close or merge PR
once you have setup.
https://urldefense.proofpoint.com/v2/url?u=https-3A__gitbox.apache.org_setup_&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=pcxZvCQyESWay4DCuwO7dXLiJ4NahPw6YN0LJ8XEt6k&m=5OAdnPdjB7MWuNmwpl8rTeTgnssXSiZBDAdqBVIXN3Y&s=w_sdA4b0XbpDJEovGRfNhSfrLlIRAmwE56belivrBQU&e=
________________________________
From: Adrian Schüpbach <ad...@gribex.net>
Sent: Tuesday, June 11, 2019 2:41:54 PM
To: dev@crail.apache.org
Subject: Re: Close PR right on Github page
Hi Julian
Thanks for your answer. Right, "Close #nnn" has worked for me,
in some cases I'd prefer that a PR, which we really can not accept,
does not even create a history, so a commit with "Close #nnn"
would not be the right approach in those cases.
I will ask INFRA how to set permissions. Since some of us
have the "Close" button on the GitHUB UI, it must be
possible somehow to configure this.
Thanks
Adrian
On 11.06.2019 19:48, Julian Hyde wrote:
> I suspect that closing a PR from the Github UI may be possible now we
have gitbox, if permissions are set correctly. But I don’t know how to set
permissions. You could try asking INFRA in hipchat.
>
> The method I use isn’t pretty but it has worked for a long time. Add a
comment ‘Close #nnn’ or ‘Closes #nnn’ or ‘Close
apache/incubator-crail#nnn’ on its own line in a commit message. When the
commit is merged into master the bot will close the PR.
>
> Julian
>
>
>> On Jun 11, 2019, at 1:05 AM, Adrian Schuepbach <DR...@zurich.ibm.com>
wrote:
>>
>> Hi Julian
>>
>> It seems that I do not have the right to close (or merge) a PR. The
>> button just does not appear for me. I thought that when I linked my
GitHub
>> account with my Apache ID I got the rights, but now I don't have them.
>>
>> Might those rights have been lost after migrating to gitbox?
>>
>> I am still able to merge changes via the command line. But it would
>> be great, if I could also close (or merge) PRs on the website.
>>
>> What should I do to get these rights again?
>>
>> Thanks
>> Adrian
>>
>>
>
Re: Close PR right on Github page
Posted by Felix Cheung <fe...@hotmail.com>.
Adrian, did you link your account? You should be able to close or merge PR once you have setup.
https://gitbox.apache.org/setup/
________________________________
From: Adrian Schüpbach <ad...@gribex.net>
Sent: Tuesday, June 11, 2019 2:41:54 PM
To: dev@crail.apache.org
Subject: Re: Close PR right on Github page
Hi Julian
Thanks for your answer. Right, "Close #nnn" has worked for me,
in some cases I'd prefer that a PR, which we really can not accept,
does not even create a history, so a commit with "Close #nnn"
would not be the right approach in those cases.
I will ask INFRA how to set permissions. Since some of us
have the "Close" button on the GitHUB UI, it must be
possible somehow to configure this.
Thanks
Adrian
On 11.06.2019 19:48, Julian Hyde wrote:
> I suspect that closing a PR from the Github UI may be possible now we have gitbox, if permissions are set correctly. But I don’t know how to set permissions. You could try asking INFRA in hipchat.
>
> The method I use isn’t pretty but it has worked for a long time. Add a comment ‘Close #nnn’ or ‘Closes #nnn’ or ‘Close apache/incubator-crail#nnn’ on its own line in a commit message. When the commit is merged into master the bot will close the PR.
>
> Julian
>
>
>> On Jun 11, 2019, at 1:05 AM, Adrian Schuepbach <DR...@zurich.ibm.com> wrote:
>>
>> Hi Julian
>>
>> It seems that I do not have the right to close (or merge) a PR. The
>> button just does not appear for me. I thought that when I linked my GitHub
>> account with my Apache ID I got the rights, but now I don't have them.
>>
>> Might those rights have been lost after migrating to gitbox?
>>
>> I am still able to merge changes via the command line. But it would
>> be great, if I could also close (or merge) PRs on the website.
>>
>> What should I do to get these rights again?
>>
>> Thanks
>> Adrian
>>
>>
>
Re: Close PR right on Github page
Posted by Adrian Schüpbach <ad...@gribex.net>.
Hi Julian
Thanks for your answer. Right, "Close #nnn" has worked for me,
in some cases I'd prefer that a PR, which we really can not accept,
does not even create a history, so a commit with "Close #nnn"
would not be the right approach in those cases.
I will ask INFRA how to set permissions. Since some of us
have the "Close" button on the GitHUB UI, it must be
possible somehow to configure this.
Thanks
Adrian
On 11.06.2019 19:48, Julian Hyde wrote:
> I suspect that closing a PR from the Github UI may be possible now we have gitbox, if permissions are set correctly. But I don’t know how to set permissions. You could try asking INFRA in hipchat.
>
> The method I use isn’t pretty but it has worked for a long time. Add a comment ‘Close #nnn’ or ‘Closes #nnn’ or ‘Close apache/incubator-crail#nnn’ on its own line in a commit message. When the commit is merged into master the bot will close the PR.
>
> Julian
>
>
>> On Jun 11, 2019, at 1:05 AM, Adrian Schuepbach <DR...@zurich.ibm.com> wrote:
>>
>> Hi Julian
>>
>> It seems that I do not have the right to close (or merge) a PR. The
>> button just does not appear for me. I thought that when I linked my GitHub
>> account with my Apache ID I got the rights, but now I don't have them.
>>
>> Might those rights have been lost after migrating to gitbox?
>>
>> I am still able to merge changes via the command line. But it would
>> be great, if I could also close (or merge) PRs on the website.
>>
>> What should I do to get these rights again?
>>
>> Thanks
>> Adrian
>>
>>
>
Re: Close PR right on Github page
Posted by Julian Hyde <jh...@apache.org>.
I suspect that closing a PR from the Github UI may be possible now we have gitbox, if permissions are set correctly. But I don’t know how to set permissions. You could try asking INFRA in hipchat.
The method I use isn’t pretty but it has worked for a long time. Add a comment ‘Close #nnn’ or ‘Closes #nnn’ or ‘Close apache/incubator-crail#nnn’ on its own line in a commit message. When the commit is merged into master the bot will close the PR.
Julian
> On Jun 11, 2019, at 1:05 AM, Adrian Schuepbach <DR...@zurich.ibm.com> wrote:
>
> Hi Julian
>
> It seems that I do not have the right to close (or merge) a PR. The
> button just does not appear for me. I thought that when I linked my GitHub
> account with my Apache ID I got the rights, but now I don't have them.
>
> Might those rights have been lost after migrating to gitbox?
>
> I am still able to merge changes via the command line. But it would
> be great, if I could also close (or merge) PRs on the website.
>
> What should I do to get these rights again?
>
> Thanks
> Adrian
>
>