[GitHub] betodealmeida opened a new pull request #5524: A tagging system for dashboards, charts and queries

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #5524: A tagging system for dashboards, charts and queries
URL: https://github.com/apache/incubator-superset/pull/5524
 
 
   This PR introduces a tagging system for Superset, allowing dashboards, charts and queries to be tagged. It also allows searching for a given tag, and will be the basis for a new landing page (see https://github.com/apache/incubator-superset/issues/5327).
   
   # Adding tags
   
   Here's an example showing adding tags to a chart (dashboards work the same way). Suggestions come from pre-existing tags, and are ordered by popularity:
   
   ![add_tag](https://user-images.githubusercontent.com/1534870/43427621-3564d936-940f-11e8-9912-6aba03280099.gif)
   
   And here's how it looks like when a user is not an owner of the chart/dashboard:
   
   <img width="419" alt="screen shot 2018-07-30 at 3 44 31 pm" src="https://user-images.githubusercontent.com/1534870/43427675-7ae8e326-940f-11e8-854b-293e8b90d377.png">
   
   # Searching for tags
   
   Clicking on a tag will take the user to a page searching for that tag. For example, clicking on the "test" tag:
   
   <img width="1680" alt="screen shot 2018-07-30 at 3 45 50 pm" src="https://user-images.githubusercontent.com/1534870/43427705-a8b85e80-940f-11e8-8ed7-601fa52d439e.png">
   
   For this, I added a new tab "Tags" to the welcome page, using the same layout as the "Favorites" tab. I changed the page so that the active tab can be specified by the URL anchor, as well as the search parameter. For example, the URL `/superset/welcome?q=test#tags` will show the "Tags" tab instead of the default "Dashboards" with the search form pre-populated with "test".
   
   # Implicit tags
   
   Dashboard, chart and (saved) queries have implicit tags related to their owners, types and favorites. For example, all objects owned by the admin have the tag `owner:1`. All charts have the tag `type:chart`. Objects favorited by the admin have the tag `favorited_by:1`.
   
   These tags are automatically added by a migration script, and kept in sync through SQLAlchemy event listeners. They are currently not surfaced to the user, but can be searched for. For example, it's possible to search for `owner:1` in the welcome page to see all objects owned by the admin, or even search for `owner:{{ current_user_id() }}`.
   
   # Queries
   
   Currently queries cannot be tagged, because I wasn't sure were to add the component. Any suggestions, @vylc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org