You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/09/27 13:11:35 UTC
[GitHub] [carbondata] nihal0107 opened a new pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
nihal0107 opened a new pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225
### Why is this PR needed?
Current load fails when table contains SI and column_meta_cache on same columns with to_date() UDF.
### What changes were proposed in this PR?
Handle null pointer when pushdownfilter is null at the time of creating new IndexFilter in CarbonDataSourceScanHelper.
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#discussion_r719118343
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/CarbonDataSourceScanHelper.scala
##########
@@ -63,8 +63,11 @@ abstract class CarbonDataSourceScanHelper(relation: CarbonDatasourceHadoopRelati
.map(CarbonToSparkAdapter.normalizeExpressions(_, output))
@transient lazy val indexFilter: IndexFilter = {
- val filter = pushedDownFilters.reduceOption(new AndExpression(_, _))
- .map(new IndexFilter(relation.carbonTable, _, true)).orNull
+ var filter: IndexFilter = null
Review comment:
same as above comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933334415
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4245/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-935814001
@nihal0107 please update PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933220241
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933589901
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933457550
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5992/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-928889066
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/353/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937035409
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/410/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937513752
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4269/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931938765
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5982/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931931356
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5980/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931965947
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4236/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937507701
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-928888854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937043133
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6011/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937041684
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4266/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933601673
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5994/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931931580
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931908157
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-928888854
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-934330430
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4252/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-935576170
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-934327092
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5998/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931296628
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-936098742
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/405/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937507701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-935873392
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-928889323
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5952/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931904457
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4233/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-934320899
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/397/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931204807
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933342344
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5991/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931902627
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931211101
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4223/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-935824270
> @nihal0107 please update PR description
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933462986
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-927977158
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-936763379
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on a change in pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on a change in pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#discussion_r719182738
##########
File path: integration/spark/src/main/common2.3and2.4/org/apache/spark/sql/CarbonDataSourceScanHelper.scala
##########
@@ -56,8 +56,11 @@ abstract class CarbonDataSourceScanHelper(relation: CarbonDatasourceHadoopRelat
.map(QueryPlan.normalizeExprId(_, output))
@transient lazy val indexFilter: IndexFilter = {
- val filter = pushedDownFilters.reduceOption(new AndExpression(_, _))
- .map(new IndexFilter(relation.carbonTable, _, true)).orNull
+ var filter: IndexFilter = null
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931942431
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/381/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931309790
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4226/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-927995499
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-927996713
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#discussion_r719117940
##########
File path: integration/spark/src/main/common2.3and2.4/org/apache/spark/sql/CarbonDataSourceScanHelper.scala
##########
@@ -56,8 +56,11 @@ abstract class CarbonDataSourceScanHelper(relation: CarbonDatasourceHadoopRelat
.map(QueryPlan.normalizeExprId(_, output))
@transient lazy val indexFilter: IndexFilter = {
- val filter = pushedDownFilters.reduceOption(new AndExpression(_, _))
- .map(new IndexFilter(relation.carbonTable, _, true)).orNull
+ var filter: IndexFilter = null
Review comment:
No need to handle here. In CarbonDataSourceScan.doCanonicalize, instead of passing null, can pass Seq.empty for pushedDownFilters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933361719
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933457353
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/391/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931210344
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931206015
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-931306394
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933563171
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4248/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937514615
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937438393
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-937438393
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-935859004
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4225: [CARBONDATA-4243] Fixed si with column meta cache on same column
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4225:
URL: https://github.com/apache/carbondata/pull/4225#issuecomment-933353538
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/390/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org