[GitHub] [spark] wzhfy commented on a change in pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

[GitBox <gi...@apache.org>]

wzhfy commented on a change in pull request #29764:
URL: https://github.com/apache/spark/pull/29764#discussion_r488850811



##########
File path: core/src/test/scala/org/apache/spark/rpc/netty/InboxSuite.scala
##########
@@ -147,4 +147,18 @@ class InboxSuite extends SparkFunSuite {
 
     endpoint.verifySingleOnNetworkErrorMessage(cause, remoteAddress)
   }
+
+  test("SPARK-32738: should reduce the number of active threads when fatal error happens") {
+    val endpoint = mock(classOf[TestRpcEndpoint])
+    when(endpoint.receive).thenThrow(new OutOfMemoryError())
+
+    val endpointRef = mock(classOf[NettyRpcEndpointRef])
+    val dispatcher = mock(classOf[Dispatcher])
+    val inbox = new Inbox(endpointRef, endpoint)

Review comment:
       Here in 2.4 we pass an `endpointRef` as parameter instead of a `name` in 3.x




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org