You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/03/09 13:16:24 UTC

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

GitHub user r-kamath opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/772

    Hot fix grunt failure

    ### What is this PR for?
    This is a fix for grunt failure due to jshint warnings
    
    Grunt error:
    `src/app/notebook/paragraph/paragraph.controller.js
      line 117   col 80  Strings must use singlequote.
      line 2122  col 83  Expected '!==' and instead saw '!='.`
    
    ### What type of PR is it?
    Hot Fix
    
    ### What is the Jira issue?
    no
    
    ### How should this be tested?
    `cd zeppelin-web` and run `grunt` should build without any error/warning
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/incubator-zeppelin fixGruntFailure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #772
    
----
commit 9e70660b955e55d207f66c82270cf90afca3bacd
Author: Renjith Kamath <re...@gmail.com>
Date:   2016-03-09T12:11:24Z

    Hot fix grunt failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195013640
  
    earlier test failure was:
    ```
    [31m- should provide onclick method *** FAILED ***
      The code passed to eventually never returned normally. Attempted 1 times over 670.613569 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:72)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194766282
  
    looks like the failure is not related to this change
    
    31m*** 1 TEST FAILED ***
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO] 
    [INFO] Zeppelin ........................................... SUCCESS [01:50 min]
    [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 37.746 s]
    [INFO] Zeppelin: Zengine .................................. SUCCESS [ 17.118 s]
    [INFO] Zeppelin: Display system apis ...................... FAILURE [ 29.541 s]
    [INFO] Zeppelin: Spark dependencies ....................... SKIPPED
    [INFO] Zeppelin: Spark .................................... SKIPPED


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194347450
  
    Thanks for the fix, and making grunt run again.
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194745698
  
    @corneadoug good find. fixed in 23638b6. thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194623195
  
    This issue made me see a bug in the grunt file. (Since build is not failing)
    Could you fix it at the same time?
    
    In Gruntfile.js: (Around [those lines](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/Gruntfile.js#L451))
    * The default task content should be: `'build', 'test'`
    * The `'newer:jshint'` that is currently in the default, should be move to the first line of the build task


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194763990
  
    LGTM, I'm trying to figure out why the CI is failing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195128515
  
    @r-kamath Could you re-trigger the CI to be sure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/772


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195203194
  
    right, CI passed clean as of the last run from yesterday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hot fix grunt failure

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195144733
  
    Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---