You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/19 22:30:27 UTC
[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request
#4148: [TE] detection - two side threshold filter
xiaohui-sun commented on a change in pull request #4148: [TE] detection - two side threshold filter
URL: https://github.com/apache/incubator-pinot/pull/4148#discussion_r277105587
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/PercentageChangeRuleAnomalyFilterSpec.java
##########
@@ -21,9 +21,11 @@
public class PercentageChangeRuleAnomalyFilterSpec extends AbstractSpec {
private String timezone = "UTC";
- private double threshold = Double.NaN;
private String offset;
private String pattern= "UP_OR_DOWN";
+ private double threshold = 0.0; // by default set threshold to 0 to pass all anomalies
+ private double upThreshold = Double.NaN;
Review comment:
Why default value is NaN?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org