[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2945: Core: Add new writer interfaces

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2945:
URL: https://github.com/apache/iceberg/pull/2945#discussion_r707757939



##########
File path: core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -56,10 +57,17 @@ public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format, String
     this.equalityFieldIds = equalityFieldIds;
   }
 
+  @Override
+  public void write(T row) throws IOException {
+    appender.add(row);
+  }
+
+  @Deprecated

Review comment:
       I'll be up for that. I did not do this in this WIP PR to avoid touching more places. I think this is a low-level API which we can break.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org