[jira] [Commented] (JCR-3852) [jackrabbit-aws-ext] Refactor code to open S3 service & consolidate testcases

["Amit Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348289#comment-14348289 ] 

Amit Jain commented on JCR-3852:
--------------------------------

The change you made to remove the tearDown means that the temp directories are not cleaned up at all. When I add the method back I get the following error
{noformat}
Exception in thread "s3-write-worker-3" com.amazonaws.AmazonClientException: sleep interrupted
        at com.amazonaws.http.AmazonHttpClient.pauseBeforeNextRetry(AmazonHttpClient.java:1147)
        at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:669)
        at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:461)
        at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:296)
        at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:3736)
        at com.amazonaws.services.s3.AmazonS3Client.getObjectMetadata(AmazonS3Client.java:1027)
        at com.amazonaws.services.s3.AmazonS3Client.getObjectMetadata(AmazonS3Client.java:1005)
        at org.apache.jackrabbit.aws.ext.ds.S3Backend.write(S3Backend.java:607)
        at org.apache.jackrabbit.aws.ext.ds.S3Backend.access$400(S3Backend.java:71)
        at org.apache.jackrabbit.aws.ext.ds.S3Backend$AsyncUploadJob.run(S3Backend.java:897)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:744)
Caused by: java.lang.InterruptedException: sleep interrupted
        at java.lang.Thread.sleep(Native Method)
        at com.amazonaws.http.AmazonHttpClient.pauseBeforeNextRetry(AmazonHttpClient.java:1144)
        ... 12 more
{noformat}

Which likely is caused by async threads not getting cleaned up and not finding the cleaned up directory. So, shouldn't the async threads be cleaned up rather than not deleting the directories? 

> [jackrabbit-aws-ext] Refactor code to open S3 service & consolidate testcases
> -----------------------------------------------------------------------------
>
>                 Key: JCR-3852
>                 URL: https://issues.apache.org/jira/browse/JCR-3852
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-data
>    Affects Versions: 2.9.1
>            Reporter: Shashank Gupta
>            Priority: Minor
>             Fix For: 2.9.1
>
>         Attachments: JCR-3852.patch, JCR-3852_v_1.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)