You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 00:27:59 UTC

[GitHub] [airflow] casassg opened a new issue #12726: Add classic operator in TaskFlow API tutorial

casassg opened a new issue #12726:
URL: https://github.com/apache/airflow/issues/12726


   
   **Description**
   
   TaskFlow API tutorial should add an example to use a classic operator (example: EmailOperator) so that users know that it can be leveraged. 
   
   Alternatively, it should add references to how to add dependencies (implicit or explicit) to classic operators.
   
   **Use case / motivation**
   
   It's not super clear how can TaskFlow API be used with existing operators (aka PostgresOperator, EmailOperator...). Adding an example, will facilitate users to get a picture of what can be done with this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] casassg commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
casassg commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-775295522


   This is good. I think the example should include using `.outputs` though (aka implicit dependencies for traditional operators).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-945895789


   @eladkal Perhaps this has already been taken care of looking at the latest TaskFlow API Tutorial doc (starting [here](https://airflow.apache.org/docs/apache-airflow/stable/tutorial_taskflow_api.html#adding-dependencies-to-decorated-tasks-from-regular-tasks)). WDYT? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-985154006


   Does anyone else agree that this can be closed now via existing docs + merging of #19124?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell edited a comment on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell edited a comment on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-955131366


   @eladkal #19214 was merged earlier. I believe this issue can be closed if you agree. This PR (and even the existing tutorial doc) has a few examples of classic operator use with TaskFlow API and generally with AIP-31.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-944918034


   @eladkal @vikramkoka Following up on this. Feel free to assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-955131366


   @eladkal #19214 was merged earlier. I believe if this issue can be closed if you agree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #12726:
URL: https://github.com/apache/airflow/issues/12726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-865413797


   @vikramkoka @casassg Is this type of example still desired? I can help contribute if it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] josh-fell commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-865413797


   @vikramkoka @casassg Is this type of example still desired? I can help contribute if it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-986320786


   Fine for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] anilkulkarni87 commented on issue #12726: Add classic operator in TaskFlow API tutorial

Posted by GitBox <gi...@apache.org>.
anilkulkarni87 commented on issue #12726:
URL: https://github.com/apache/airflow/issues/12726#issuecomment-775025413


   @casassg 
   Here is an example I have created and this dag implements taskgroup, taskflow with classic operators. Please take a look:
   [Postgres DAG with Taskgroup and Taskflow](https://github.com/anilkulkarni87/airflow-docker/blob/master/dags/postgres_taskgroup.py)
   
   Here is how the dependency looks like on UI:
   ![image](https://user-images.githubusercontent.com/10644132/107204541-a13a1c00-69b1-11eb-9139-7827e360ec67.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org