You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/24 02:04:28 UTC
[GitHub] [hive] dh20 commented on pull request #2103: HIVE-24922 Remove redundant code and improve readability
dh20 commented on pull request #2103:
URL: https://github.com/apache/hive/pull/2103#issuecomment-805416930
> Please add a more specific commit message, something that refers to the fact that you are removing those codes from ExecDriver
ok.sir
1. In the mwork object, nummaptasks, maxsplitsize, minsplitsize, minsplitsize pernode, minsplitsize perrack, numreeducetasks have been added. Declaration becomes the corresponding value type, so I don't think it's necessary to use longvalue () and intvalue () to get them, which is redundant
2. getcurrentdb() is only used in the current class execdriver class, so it should be modified by private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org