You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/11 07:33:47 UTC

[GitHub] [dubbo-go] PhilYue opened a new issue #1584: JSON-RPC protocol, config request timeout

PhilYue opened a new issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584


   <!-- Please only use this template for submitting enhancement requests -->
   
   **What would you like to be added**:
   ```
   // Refer a remote JSON PRC service from registry
   func (jp *JsonrpcProtocol) Refer(url *common.URL) protocol.Invoker {
   	// default requestTimeout
   	// todo config timeout
   	requestTimeout := time.Duration(3 * time.Second) //config.GetConsumerConfig().RequestTimeout
   
   	// todo config timeout
   	requestTimeoutStr := "3s" //url.GetParam(constant.TIMEOUT_KEY, config.GetConsumerConfig().Request_Timeout)
   	if t, err := time.ParseDuration(requestTimeoutStr); err == nil {
   		requestTimeout = t
   	}
   
   	invoker := NewJsonrpcInvoker(url, NewHTTPClient(&HTTPOptions{
   		HandshakeTimeout: time.Second, // todo config timeout config.GetConsumerConfig().ConnectTimeout,
   		HTTPTimeout:      requestTimeout,
   	}))
   	jp.SetInvokers(invoker)
   	logger.Infof("[JSONRPC Protocol] Refer service: %s", url.String())
   	return invoker
   }
   ```
   **Why is this needed**:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] justxuewei closed issue #1584: JSON-RPC protocol, config request timeout

Posted by GitBox <gi...@apache.org>.
justxuewei closed issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] PhilYue commented on issue #1584: JSON-RPC protocol, config request timeout

Posted by GitBox <gi...@apache.org>.
PhilYue commented on issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584#issuecomment-990751024


   suspend...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] sunrui1225 commented on issue #1584: JSON-RPC protocol, config request timeout

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584#issuecomment-1013651452


   have pull request. Pls revew https://github.com/apache/dubbo-go/pull/1713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks closed issue #1584: JSON-RPC protocol, config request timeout

Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] justxuewei commented on issue #1584: JSON-RPC protocol, config request timeout

Posted by GitBox <gi...@apache.org>.
justxuewei commented on issue #1584:
URL: https://github.com/apache/dubbo-go/issues/1584#issuecomment-1013135593


   @sunrui1225 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org