You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/10 04:06:05 UTC
[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
ZihanLi58 opened a new pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1256
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
This PR exclude all the log4j related jar from our published artifacts except gobblin-aws to provide a clean dependency for user. After this change, user who depend on gobblin will need to specify the log implementation in their project, i.e log4jV1 or log4jV2.
Also this pr remain the log4j related dependency in unit test since we still use Log4j API to test.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Run unit test
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691333583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487298251
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691332372
It is also worth noting that tests like `LoggingPusherTest` will not work if running in IntellIJ without removing bridging jar from external library directories. So it will be better to document this kind of "Gotcha" as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487298251
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691333583
> It is also worth noting that tests like `LoggingPusherTest` will not work if running in IntellIJ without removing bridging jar from external library directories. So it will be better to document this kind of "Gotcha" as well.
I haven't meet this error in intellij, maybe it randomly picks the right jar for me, will add this into the document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691332372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691333583
> It is also worth noting that tests like `LoggingPusherTest` will not work if running in IntellIJ without removing bridging jar from external library directories. So it will be better to document this kind of "Gotcha" as well.
I haven't meet this error in intellij, maybe it randomly picks the right jar for me, will add this into the document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-690509660
@autumnust Can you help take a look at this change? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487298251
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487298251
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
I might miss something obvious here: why this line (used for exclusion) is no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487312036
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r489031738
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
Got it. Missed exclamation mark ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487312036
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691332372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#issuecomment-691333583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3099: [GOBBLIN-1256]Exclude log4j related jars in compile but include those in test
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #3099:
URL: https://github.com/apache/incubator-gobblin/pull/3099#discussion_r487312036
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
##########
File path: gradle/scripts/globalDependencies.gradle
##########
@@ -35,20 +36,36 @@ subprojects {
compile(externalDependency.guava) {
force = true
}
- }
- compile(externalDependency.commonsCodec) {
- force = true
- }
+ }
+ compile(externalDependency.commonsCodec) {
+ force = true
+ }
+ //Since testCompile inherit from compile, so we cannot use testCompile to import dependency for log4j
+ customTestCompile externalDependency.log4j
+ customTestCompile externalDependency.slf4jToLog4j
// Required to add JDK's tool jar, which is required to run byteman tests.
testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs()))
}
+ if (!project.name.contains('gobblin-aws')) {
+ configurations.compile.dependencies*.each {
+ //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
+ it.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ //exclude log4j related jars to provide a clean log environment
+ it.exclude group: 'log4j', module: 'log4j'
+ it.exclude group: 'log4j', module: 'apache-log4j-extras'
+ }
+ }
all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
- //exclude this jar because we introduce log4j-over-slf4j, these two jars cannot present at the same time
- compileClasspath.exclude group: 'org.slf4j', module: 'slf4j-log4j12'
Review comment:
On Line51 (configurations.compile.dependencies*.each ) I add the config to exclude slf4j-log4j12 and log4j related jar. The reason for using this statement is that I find when we call compile.exclude to exclude some jar, the published artifacts will still contains that transient dependency. So I use this statement to make sure our published artifacts do not contains log4j related dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org