[jira] [Commented] (TAJO-2150) Fix invalid implementation of date time in jdbc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287835#comment-15287835 ] 

ASF GitHub Bot commented on TAJO-2150:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/1025#issuecomment-219880467
  
    +1 LGTM! Ship it.


> Fix invalid implementation of date time in jdbc
> -----------------------------------------------
>
>                 Key: TAJO-2150
>                 URL: https://issues.apache.org/jira/browse/TAJO-2150
>             Project: Tajo
>          Issue Type: Bug
>          Components: JDBC Driver
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>
> The jdbc spec is as following:
> 'This method uses the given calendar to construct an appropriate millisecond
value for the time if the underlying database does not store
 timezone information.'
> We should correctly fix implementations
> {noformat}
> java.sql.Time getTime(int columnIndex, Calendar cal) throws SQLException;
> java.sql.Date getDate(int columnIndex, Calendar cal) throws SQLException;
> java.sql.Timestamp getTimestamp(int columnIndex, Calendar cal) throws SQLException;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)