You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/03 16:58:06 UTC
[GitHub] [iotdb] ZhanGHanG9991 opened a new pull request, #5787: [IoTDB-2992] Add JEXL in UDF
ZhanGHanG9991 opened a new pull request, #5787:
URL: https://github.com/apache/iotdb/pull/5787
## Description
Add JEXL in UDF
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #5787: [IOTDB-2992] Add JEXL in UDF
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged PR #5787:
URL: https://github.com/apache/iotdb/pull/5787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #5787: [IOTDB-2992] Add JEXL in UDF
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on code in PR #5787:
URL: https://github.com/apache/iotdb/pull/5787#discussion_r864413667
##########
server/src/main/java/org/apache/iotdb/db/query/udf/builtin/UDTFJexl.java:
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.udf.builtin;
+
+import org.apache.iotdb.commons.exception.MetadataException;
+import org.apache.iotdb.db.exception.query.QueryProcessException;
+import org.apache.iotdb.db.query.udf.api.UDTF;
+import org.apache.iotdb.db.query.udf.api.access.Row;
+import org.apache.iotdb.db.query.udf.api.collector.PointCollector;
+import org.apache.iotdb.db.query.udf.api.customizer.config.UDTFConfigurations;
+import org.apache.iotdb.db.query.udf.api.customizer.parameter.UDFParameterValidator;
+import org.apache.iotdb.db.query.udf.api.customizer.parameter.UDFParameters;
+import org.apache.iotdb.db.query.udf.api.customizer.strategy.RowByRowAccessStrategy;
+import org.apache.iotdb.db.query.udf.api.exception.UDFException;
+import org.apache.iotdb.db.query.udf.api.exception.UDFInputSeriesDataTypeNotValidException;
+import org.apache.iotdb.db.query.udf.api.exception.UDFOutputSeriesDataTypeNotValidException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+
+import org.apache.commons.jexl3.JexlBuilder;
+import org.apache.commons.jexl3.JexlEngine;
+import org.apache.commons.jexl3.JexlScript;
+
+import java.io.IOException;
+
+public class UDTFJexl implements UDTF {
+
+ private TSDataType inputDataType;
+ private TSDataType outputDataType;
+ private String expr;
+ private JexlScript script;
+
+ @Override
+ public void validate(UDFParameterValidator validator) throws UDFException {
+ validator
+ .validateInputSeriesNumber(1)
+ .validateInputSeriesDataType(
+ 0,
+ TSDataType.INT32,
+ TSDataType.INT64,
+ TSDataType.FLOAT,
+ TSDataType.DOUBLE,
+ TSDataType.TEXT,
+ TSDataType.BOOLEAN)
+ .validateRequiredAttribute("expr");
+ }
+
+ @Override
+ public void beforeStart(UDFParameters parameters, UDTFConfigurations configurations)
+ throws UDFInputSeriesDataTypeNotValidException, UDFOutputSeriesDataTypeNotValidException,
+ MetadataException {
+ expr = parameters.getString("expr");
+ JexlEngine jexl = new JexlBuilder().create();
+ script = jexl.createScript(expr);
+
+ inputDataType = parameters.getDataType(0);
+ outputDataType = getOutputDataType(inputDataType);
+
+ configurations
+ .setAccessStrategy(new RowByRowAccessStrategy())
+ .setOutputDataType(outputDataType);
+ }
+
+ @Override
+ public void transform(Row row, PointCollector collector)
+ throws IOException, UDFOutputSeriesDataTypeNotValidException, QueryProcessException {
+ switch (outputDataType) {
+ case INT32:
+ collector.putInt(row.getTime(), (Integer) script.execute(null, row.getInt(0)));
+ break;
+ case INT64:
+ collector.putLong(row.getTime(), (Long) script.execute(null, row.getLong(0)));
+ break;
+ case FLOAT:
+ collector.putFloat(row.getTime(), (Float) script.execute(null, row.getFloat(0)));
+ break;
+ case DOUBLE:
+ {
+ if (inputDataType == TSDataType.FLOAT) {
+ collector.putDouble(row.getTime(), (Double) script.execute(null, row.getFloat(0)));
+ } else {
+ collector.putDouble(row.getTime(), (Double) script.execute(null, row.getDouble(0)));
+ }
+ break;
+ }
+ case TEXT:
+ collector.putString(row.getTime(), (String) script.execute(null, row.getString(0)));
+ break;
+ case BOOLEAN:
+ collector.putBoolean(row.getTime(), (Boolean) script.execute(null, row.getBoolean(0)));
+ break;
+ default:
+ // This will not happen.
+ throw new UDFOutputSeriesDataTypeNotValidException(
+ 0,
+ TSDataType.INT32,
+ TSDataType.INT64,
+ TSDataType.DOUBLE,
+ TSDataType.TEXT,
+ TSDataType.BOOLEAN);
+ }
+ }
+
+ public TSDataType getOutputDataType(TSDataType inputDataType)
+ throws UDFInputSeriesDataTypeNotValidException, UDFOutputSeriesDataTypeNotValidException {
+ Object o;
+ switch (inputDataType) {
+ case INT32:
+ o = script.execute(null, (int) 23);
+ break;
+ case INT64:
+ o = script.execute(null, (long) 23);
+ break;
+ case FLOAT:
+ o = script.execute(null, 23f);
+ assert o instanceof Double;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org