You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/08/13 17:28:36 UTC
Review Request 24651: Fix bug in deprecation warning for cancel-update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24651/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Joe Smith.
Bugs: aurora-650
https://issues.apache.org/jira/browse/aurora-650
Repository: aurora
Description
-------
While working on improving the coverage of our end-to-end tests,
I discovered a cut-and-paste error in the implementation of the
warning message for cancel_update.
This is a quick-fix for this problem. Testing for this will be included
in the testing coverage changes that I'm working on.
Diffs
-----
src/main/python/apache/aurora/client/commands/core.py da9d9a0a2206c83a225071de570bc0fe406b29f4
Diff: https://reviews.apache.org/r/24651/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 24651: Fix bug in deprecation warning for cancel-update.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24651/#review50477
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Aug. 13, 2014, 3:28 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24651/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 3:28 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Joe Smith.
>
>
> Bugs: aurora-650
> https://issues.apache.org/jira/browse/aurora-650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> While working on improving the coverage of our end-to-end tests,
> I discovered a cut-and-paste error in the implementation of the
> warning message for cancel_update.
>
> This is a quick-fix for this problem. Testing for this will be included
> in the testing coverage changes that I'm working on.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py da9d9a0a2206c83a225071de570bc0fe406b29f4
>
> Diff: https://reviews.apache.org/r/24651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 24651: Fix bug in deprecation warning for cancel-update.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24651/#review50475
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Aug. 13, 2014, 8:28 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24651/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 8:28 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Joe Smith.
>
>
> Bugs: aurora-650
> https://issues.apache.org/jira/browse/aurora-650
>
>
> Repository: aurora
>
>
> Description
> -------
>
> While working on improving the coverage of our end-to-end tests,
> I discovered a cut-and-paste error in the implementation of the
> warning message for cancel_update.
>
> This is a quick-fix for this problem. Testing for this will be included
> in the testing coverage changes that I'm working on.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py da9d9a0a2206c83a225071de570bc0fe406b29f4
>
> Diff: https://reviews.apache.org/r/24651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>