You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 17:27:18 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9170: ARROW-11176: [R] Expose memory pool name and document setting it

pitrou commented on a change in pull request #9170:
URL: https://github.com/apache/arrow/pull/9170#discussion_r555946108



##########
File path: cpp/src/arrow/memory_pool.cc
##########
@@ -87,6 +87,19 @@ const char* je_arrow_malloc_conf =
 #endif  // ARROW_JEMALLOC
 
 namespace arrow {
+
+std::vector<std::string> SupportedBackendNames() {

Review comment:
       It would be better to reuse `SupportedBackends` below. Otherwise we risk this function being out of sync.

##########
File path: r/R/arrow-package.R
##########
@@ -76,6 +76,39 @@ option_use_threads <- function() {
   !is_false(getOption("arrow.use_threads"))
 }
 
+#' Report information on the package's capabilities
+#'
+#' This function summarizes a number of build-time configurations and run-time
+#' settings for the Arrow package. It may be useful for diagnostics.
+#' @return A list including version information, boolean "capabilities", and
+#' statistics from Arrow's memory allocator.

Review comment:
       Does it make sense to include runtime statistics together with static configuration information?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org