You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Shmakov Alexey (Jira)" <ji...@apache.org> on 2023/03/02 21:26:00 UTC

[jira] [Commented] (CAMEL-19106) repair checkstyle in branch camel-3.x

    [ https://issues.apache.org/jira/browse/CAMEL-19106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695901#comment-17695901 ] 

Shmakov Alexey commented on CAMEL-19106:
----------------------------------------

[https://github.com/apache/camel/pull/9461]

 

> repair  checkstyle  in branch camel-3.x
> ---------------------------------------
>
>                 Key: CAMEL-19106
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19106
>             Project: Camel
>          Issue Type: Task
>          Components: build system
>            Reporter: Shmakov Alexey
>            Priority: Minor
>             Fix For: 3.21.0
>
>
> Checkstyle plugin fails for several components with next error in the  branch camel-3.x
> [ERROR] E:\camel-fork{_}components\camel-spring-ws\src\test\resources\org\apache\camel\component\spring\ws\addresing\ProducerParamsBasicTest-context.xml:54: *Line is longer than 250 characters (found 261). [LineLength]*{_}
>  
> It is necessary to exclude test *resources test/resources/.xml* from the style check in *maven-checkstyle-plugin*  - they are not important anyway, but this will fix the project build
>  
> I spent several hours (due to a weak computer) to fix the test files in different components one by one, but I ran into an unsolvable problem, I don’t know how to shorten the next line in the test file _components\camel-spring-ws\src\test\resources\org\apache\camel\component\spring\ws\addresing\ProducerParamsBasicTest-context.xml:60_
> <to uri="spring-ws:[http://google.com?wsAddressingAction=http://wsaAction.com&webServiceTemplate=#webServiceTemplate&replyTo=mailto://replyTo@chocolatejar.eu&endpointMapping=#endpointMapping&faultTo=http://fault.to&messageIdStrategy=#staticId|http://google.com/?wsAddressingAction=http://wsaAction.com&webServiceTemplate=#webServiceTemplate&replyTo=mailto://replyTo@chocolatejar.eu&endpointMapping=#endpointMapping&faultTo=http://fault.to&messageIdStrategy=#staticId]" />
>  
> The string is longer than 250 characters and I don't know how to shorten it so as not to break the tests. I consider it most reasonable to exclude test files from the general rule
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)