You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/02 11:01:36 UTC
[GitHub] [flink] fsk119 opened a new pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
fsk119 opened a new pull request #12805:
URL: https://github.com/apache/flink/pull/12805
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Currently users still can't use 'exactly-once' semantic in kafka table api. Therefore, we expose key `sink.semantic` and offer values `['exactly-once', 'at-least-once', 'none']` for users to use.*
## Brief change log
- *Add option in KafkaOptions*
- *Add validation for value of `sink.semantic`*
- *Use parsed value of `sink.semantic` to build KafkaProducer*
## Verifying this change
This change added tests and can be verified as follows:
- *Added integration tests for new option `sink.semantic`*
- *Added test when input invalid value for option `sink.semantic`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73c191e3077bba3681cf47fd29d14245e38082b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215)
* b2adffed86531ab0eda2bc6ca89b346228829e42 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r451950734
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaOptions.java
##########
@@ -222,8 +226,17 @@ private static void validateSinkSemantic(ReadableConfig tableOptions) {
// Utilities
// --------------------------------------------------------------------------------------------
- public static String transformSemantic(String semantic){
- return semantic.toUpperCase().replace('-', '_');
+ public static KafkaSemantic getSinkSemantic(String semantic){
Review comment:
`SinkSemantic` or `KafkaSinkSemantic`? It maybe confusing that it also works for source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1ebc4d4364388f3114145779dab8142e214c8fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170)
* 8e327aac43aa12378be70c9787862d78c99f5665 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-653839338
CC @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5083755939c4b336a879d5a4b3efae53cd2fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197)
* 73c191e3077bba3681cf47fd29d14245e38082b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318)
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713d183c321f7a6f330a9cee30bf57c439d497f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
}, {
"hash" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"triggerType" : "PUSH"
}, {
"hash" : "4e888904c81c2b13665deefe2b93398b01533459",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4e888904c81c2b13665deefe2b93398b01533459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322)
* f162377f7b801435b27e487a86dd4e06e5996f2a UNKNOWN
* 4e888904c81c2b13665deefe2b93398b01533459 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2adffed86531ab0eda2bc6ca89b346228829e42 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254)
* 5fa00643457589cc011c3308ac33efbaa86bd48c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r450703944
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/table/Kafka010DynamicTableFactory.java
##########
@@ -65,18 +74,31 @@ protected KafkaDynamicSinkBase createKafkaTableSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat,
+ String semantic) {
return new Kafka010DynamicSink(
consumedDataType,
topic,
properties,
partitioner,
- encodingFormat);
+ encodingFormat,
+ semantic);
}
@Override
public String factoryIdentifier() {
return IDENTIFIER;
}
+
+ @Override
+ public Set<ConfigOption<?>> optionalOptions() {
+ final Set<ConfigOption<?>> options = new HashSet<>();
+ options.add(PROPS_GROUP_ID);
+ options.add(SCAN_STARTUP_MODE);
+ options.add(SCAN_STARTUP_SPECIFIC_OFFSETS);
+ options.add(SCAN_STARTUP_TIMESTAMP_MILLIS);
+ options.add(SINK_PARTITIONER);
+ return options;
Review comment:
remove sink semantic option.
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/table/Kafka010DynamicTableFactoryTest.java
##########
@@ -82,12 +87,47 @@ protected KafkaDynamicSinkBase getExpectedSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat,
+ String semantic) {
+ // we only support "at-least-semantic" for kafka-0.10 connector.
+ // if users use `sink.semantic` to select behaviour for kafka-0.10 connector,
+ // he/she will get validation error of unsupported option.
return new Kafka010DynamicSink(
consumedDataType,
topic,
properties,
partitioner,
- encodingFormat);
+ encodingFormat,
+ "AT_LEAST_ONCE");
+ }
+
+ @Override
+ protected Map<String, String> getFullSinkOptions(){
+ Map<String, String> options = super.getFullSinkOptions();
+ options.remove("sink.semantic");
+ return options;
+ }
+
+ @Override
+ public void testInvalidSinkSemantic() {
+ ObjectIdentifier objectIdentifier = ObjectIdentifier.of(
+ "default",
+ "default",
+ "sinkTable");
+
+ final Map<String, String> modifiedOptions = getModifiedOptions(
+ getFullSinkOptions(),
+ options -> {
+ options.put("sink.semantic", "exactly-once");
+ });
+ final CatalogTable sinkTable = createKafkaSinkCatalogTable(modifiedOptions);
+
+ thrown.expect(ValidationException.class);
Review comment:
Please check the exception message too. If the expected message is nested in the stack, you can use `org.apache.flink.core.testutils.FlinkMatchers#containsCause` util.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
}, {
"hash" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322)
* f162377f7b801435b27e487a86dd4e06e5996f2a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12805:
URL: https://github.com/apache/flink/pull/12805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r449967255
##########
File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTestBase.java
##########
@@ -386,6 +411,7 @@ private CatalogTable createKafkaSinkCatalogTable(Map<String, String> options) {
tableOptions.put("properties.group.id", "dummy");
tableOptions.put("properties.bootstrap.servers", "dummy");
tableOptions.put("sink.partitioner", KafkaOptions.SINK_PARTITIONER_VALUE_FIXED);
+ tableOptions.put("sink.semantic", KafkaOptions.SINK_SEMANTIC_VALUE_AT_LEAST_ONCE);
Review comment:
use exactly-once to verify the configuration works, because default value is at-least-once.
##########
File path: docs/dev/table/connectors/kafka.md
##########
@@ -165,6 +165,14 @@ Connector Options
</ul>
</td>
</tr>
+ <tr>
+ <td><h5>sink.semantic</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">at-least-once</td>
+ <td>String</td>
+ <td>Optional semantic when commit. Valid enumerationns are ['at-lease-once', 'exactly-once', 'none'].
+ Only Kafka whose version greater than 1.0.0 support 'exactly-once' with checkpointing enabled.</td>
Review comment:
```suggestion
<td>Defines the delivery semantic for the Kafka sink. Valid enumerationns are <code>'at-lease-once'</code>, <code>'exactly-once'</code> and <code>'none'</code>. <code>'kafka-0.10'</code> doesn't support this option. See <a href='#consistency-guarantees'>Consistency guarantees</a> for more details. </td>
```
##########
File path: docs/dev/table/connectors/kafka.md
##########
@@ -206,6 +214,8 @@ However, it will cause a lot of network connections between all the Flink instan
### Consistency guarantees
By default, a Kafka sink ingests data with at-least-once guarantees into a Kafka topic if the query is executed with [checkpointing enabled]({% link dev/stream/state/checkpointing.md %}#enabling-and-configuring-checkpointing).
+With Kafka whose version is greater than 1.0.0, `sink.semantic` can provide exactly-once delivery guarantee. Whenever you write to Kafka using transactions, do not forget about setting the desired `isolation.level`
+(`read_committed` or `read_uncommitted` - latter one is the default value) for any application consuming records from Kafka.
Review comment:
```suggestion
With Flink's checkpointing enabled, the `kafka` and `kafka-0.11` connectors can provide exactly-once delivery guarantees.
Besides enabling Flink's checkpointing, you can also choose three different modes of operating chosen by passing appropriate `sink.semantic` option:
* `NONE`: Flink will not guarantee anything. Produced records can be lost or they can be duplicated.
* `AT_LEAST_ONCE` (default setting): This guarantees that no records will be lost (although they can be duplicated).
* `EXACTLY_ONCE`: Kafka transactions will be used to provide exactly-once semantic. Whenever you write
to Kafka using transactions, do not forget about setting desired `isolation.level` (`read_committed`
or `read_uncommitted` - the latter one is the default value) for any application consuming records
from Kafka.
Please refer to [Kafka documentation]({% link dev/connectors/kafka.md %}#kafka-producers-and-fault-tolerance) for more caveats about delivery guarantees.
```
##########
File path: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/table/Kafka011DynamicSink.java
##########
@@ -42,26 +44,31 @@ public Kafka011DynamicSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat,
+ String semantic) {
super(
consumedDataType,
topic,
properties,
partitioner,
- encodingFormat);
+ encodingFormat,
+ semantic);
}
@Override
protected SinkFunction<RowData> createKafkaProducer(
String topic,
Properties properties,
SerializationSchema<RowData> serializationSchema,
- Optional<FlinkKafkaPartitioner<RowData>> partitioner) {
+ Optional<FlinkKafkaPartitioner<RowData>> partitioner,
+ String semantic) {
return new FlinkKafkaProducer011<>(
topic,
- serializationSchema,
+ new KeyedSerializationSchemaWrapper<>(serializationSchema),
properties,
- partitioner);
+ partitioner,
+ getSemantic(semantic),
Review comment:
I suggest to move this logic into `KafkaOptions` to avoid duplicate code. You can have a table level enum class `SinkSemantic`. And simply call `FlinkKafkaProducer.Semantic.valueOf(semantic.name())` here.
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaOptions.java
##########
@@ -191,6 +208,21 @@ private static void validateSinkPartitioner(ReadableConfig tableOptions) {
});
}
+ private static void validateSinkSemantic(ReadableConfig tableOptions, String kafkaVersion) {
+ tableOptions.getOptional(SINK_SEMANTIC).ifPresent(semantic -> {
+ if (!SINK_SEMANTIC_ENUMS.contains(semantic)){
+ throw new ValidationException(
+ String.format("Unsupported value '%s' for '%s'. Supported values are ['at-least-once', 'exactly-once', 'none'].",
+ semantic, SINK_SEMANTIC.key()));
+ }
+
+ if (kafkaVersion.equals("kafka-0.10") && (!SINK_SEMANTIC_VALUE_AT_LEAST_ONCE.equals(semantic))){
Review comment:
This is indeed what we should avoid. A base class shouldn't depends on specific connector implementation. We should move this special logic into `Kafka010DynamicTableFactory`.
A simple way to disallow this option in kafka-0.10 is override `optionalOptions()` and remove `SINK_SEMANTIC` from it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r451951070
##########
File path: docs/dev/table/connectors/kafka.md
##########
@@ -207,6 +214,19 @@ However, it will cause a lot of network connections between all the Flink instan
By default, a Kafka sink ingests data with at-least-once guarantees into a Kafka topic if the query is executed with [checkpointing enabled]({% link dev/stream/state/checkpointing.md %}#enabling-and-configuring-checkpointing).
+With Flink's checkpointing enabled, the `kafka` and `kafka-0.11` connectors can provide exactly-once delivery guarantees.
+
+Besides enabling Flink's checkpointing, you can also choose three different modes of operating chosen by passing appropriate `sink.semantic` option:
+
+ * `NONE`: Flink will not guarantee anything. Produced records can be lost or they can be duplicated.
+ * `AT_LEAST_ONCE` (default setting): This guarantees that no records will be lost (although they can be duplicated).
Review comment:
```suggestion
* `at-least-once` (default setting): This guarantees that no records will be lost (although they can be duplicated).
```
##########
File path: docs/dev/table/connectors/kafka.md
##########
@@ -207,6 +214,19 @@ However, it will cause a lot of network connections between all the Flink instan
By default, a Kafka sink ingests data with at-least-once guarantees into a Kafka topic if the query is executed with [checkpointing enabled]({% link dev/stream/state/checkpointing.md %}#enabling-and-configuring-checkpointing).
+With Flink's checkpointing enabled, the `kafka` and `kafka-0.11` connectors can provide exactly-once delivery guarantees.
+
+Besides enabling Flink's checkpointing, you can also choose three different modes of operating chosen by passing appropriate `sink.semantic` option:
+
+ * `NONE`: Flink will not guarantee anything. Produced records can be lost or they can be duplicated.
+ * `AT_LEAST_ONCE` (default setting): This guarantees that no records will be lost (although they can be duplicated).
+ * `EXACTLY_ONCE`: Kafka transactions will be used to provide exactly-once semantic. Whenever you write
Review comment:
```suggestion
* `exactly-once`: Kafka transactions will be used to provide exactly-once semantic. Whenever you write
```
##########
File path: docs/dev/table/connectors/kafka.md
##########
@@ -207,6 +214,19 @@ However, it will cause a lot of network connections between all the Flink instan
By default, a Kafka sink ingests data with at-least-once guarantees into a Kafka topic if the query is executed with [checkpointing enabled]({% link dev/stream/state/checkpointing.md %}#enabling-and-configuring-checkpointing).
+With Flink's checkpointing enabled, the `kafka` and `kafka-0.11` connectors can provide exactly-once delivery guarantees.
+
+Besides enabling Flink's checkpointing, you can also choose three different modes of operating chosen by passing appropriate `sink.semantic` option:
+
+ * `NONE`: Flink will not guarantee anything. Produced records can be lost or they can be duplicated.
Review comment:
```suggestion
* `none`: Flink will not guarantee anything. Produced records can be lost or they can be duplicated.
```
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/table/Kafka010DynamicTableFactory.java
##########
@@ -65,18 +69,27 @@ protected KafkaDynamicSinkBase createKafkaTableSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat,
+ KafkaSemantic semantic) {
return new Kafka010DynamicSink(
consumedDataType,
topic,
properties,
partitioner,
- encodingFormat);
+ encodingFormat,
+ semantic);
}
@Override
public String factoryIdentifier() {
return IDENTIFIER;
}
+
+ @Override
+ public Set<ConfigOption<?>> optionalOptions() {
+ final Set<ConfigOption<?>> options = super.optionalOptions();
+ options.remove(SINK_SEMANTIC);
Review comment:
Add a comment on this to explain why we remove sink semantic in 0.10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713d183c321f7a6f330a9cee30bf57c439d497f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167)
* a1ebc4d4364388f3114145779dab8142e214c8fc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c2e909e39e980f5a538ee3826da07e5478a232 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265)
* f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318)
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a change in pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
fsk119 commented on a change in pull request #12805:
URL: https://github.com/apache/flink/pull/12805#discussion_r450119872
##########
File path: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/table/Kafka011DynamicSink.java
##########
@@ -42,26 +44,31 @@ public Kafka011DynamicSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat,
+ String semantic) {
super(
consumedDataType,
topic,
properties,
partitioner,
- encodingFormat);
+ encodingFormat,
+ semantic);
}
@Override
protected SinkFunction<RowData> createKafkaProducer(
String topic,
Properties properties,
SerializationSchema<RowData> serializationSchema,
- Optional<FlinkKafkaPartitioner<RowData>> partitioner) {
+ Optional<FlinkKafkaPartitioner<RowData>> partitioner,
+ String semantic) {
return new FlinkKafkaProducer011<>(
topic,
- serializationSchema,
+ new KeyedSerializationSchemaWrapper<>(serializationSchema),
properties,
- partitioner);
+ partitioner,
+ getSemantic(semantic),
Review comment:
I have already moved getSemantic logic from KafkaDynamicSink. However, I just add a method named `transformSemantic` to resolve the gap between KafaProducer.Semantic and value of 'sink.semantic'. This method will
transform input of 'sink.semantic' and replace '-' with '_';
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5083755939c4b336a879d5a4b3efae53cd2fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197)
* 73c191e3077bba3681cf47fd29d14245e38082b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e327aac43aa12378be70c9787862d78c99f5665 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2adffed86531ab0eda2bc6ca89b346228829e42 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254)
* 5fa00643457589cc011c3308ac33efbaa86bd48c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713d183c321f7a6f330a9cee30bf57c439d497f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167)
* a1ebc4d4364388f3114145779dab8142e214c8fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-653401122
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652940254
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 713d183c321f7a6f330a9cee30bf57c439d497f9 (Thu Jul 02 11:03:29 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c2e909e39e980f5a538ee3826da07e5478a232 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
}, {
"hash" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"triggerType" : "PUSH"
}, {
"hash" : "4e888904c81c2b13665deefe2b93398b01533459",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4369",
"triggerID" : "4e888904c81c2b13665deefe2b93398b01533459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322)
* f162377f7b801435b27e487a86dd4e06e5996f2a UNKNOWN
* 4e888904c81c2b13665deefe2b93398b01533459 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713d183c321f7a6f330a9cee30bf57c439d497f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e327aac43aa12378be70c9787862d78c99f5665 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192)
* c8d5083755939c4b336a879d5a4b3efae53cd2fb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5fa00643457589cc011c3308ac33efbaa86bd48c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262)
* d8c2e909e39e980f5a538ee3826da07e5478a232 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e327aac43aa12378be70c9787862d78c99f5665 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192)
* c8d5083755939c4b336a879d5a4b3efae53cd2fb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4322",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
}, {
"hash" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f162377f7b801435b27e487a86dd4e06e5996f2a",
"triggerType" : "PUSH"
}, {
"hash" : "4e888904c81c2b13665deefe2b93398b01533459",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4369",
"triggerID" : "4e888904c81c2b13665deefe2b93398b01533459",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* f162377f7b801435b27e487a86dd4e06e5996f2a UNKNOWN
* 4e888904c81c2b13665deefe2b93398b01533459 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713d183c321f7a6f330a9cee30bf57c439d497f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4265",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
}, {
"hash" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318",
"triggerID" : "f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910",
"triggerType" : "PUSH"
}, {
"hash" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f78c4920b6e2aa743286a9484ad5a82cd3ca40b1",
"triggerType" : "PUSH"
}, {
"hash" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "47e6d361dff7aac4cfbec6e692d1ac80add5c48d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7e2fb2f72fecef9c67fa6d9ebce0c6af3db3910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4318)
* f78c4920b6e2aa743286a9484ad5a82cd3ca40b1 UNKNOWN
* 47e6d361dff7aac4cfbec6e692d1ac80add5c48d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1ebc4d4364388f3114145779dab8142e214c8fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5083755939c4b336a879d5a4b3efae53cd2fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73c191e3077bba3681cf47fd29d14245e38082b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215)
* b2adffed86531ab0eda2bc6ca89b346228829e42 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
}, {
"hash" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262",
"triggerID" : "5fa00643457589cc011c3308ac33efbaa86bd48c",
"triggerType" : "PUSH"
}, {
"hash" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8c2e909e39e980f5a538ee3826da07e5478a232",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2adffed86531ab0eda2bc6ca89b346228829e42 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254)
* 5fa00643457589cc011c3308ac33efbaa86bd48c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4262)
* d8c2e909e39e980f5a538ee3826da07e5478a232 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1ebc4d4364388f3114145779dab8142e214c8fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170)
* 8e327aac43aa12378be70c9787862d78c99f5665 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73c191e3077bba3681cf47fd29d14245e38082b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 removed a comment on pull request #12805: [Flink-14356][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
fsk119 removed a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-653401122
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12805: [FLINK-15221][table api]support fault-tolerant semantic for kafka table api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12805:
URL: https://github.com/apache/flink/pull/12805#issuecomment-652943981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4167",
"triggerID" : "713d183c321f7a6f330a9cee30bf57c439d497f9",
"triggerType" : "PUSH"
}, {
"hash" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4170",
"triggerID" : "a1ebc4d4364388f3114145779dab8142e214c8fc",
"triggerType" : "PUSH"
}, {
"hash" : "8e327aac43aa12378be70c9787862d78c99f5665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4192",
"triggerID" : "8e327aac43aa12378be70c9787862d78c99f5665",
"triggerType" : "PUSH"
}, {
"hash" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4197",
"triggerID" : "c8d5083755939c4b336a879d5a4b3efae53cd2fb",
"triggerType" : "PUSH"
}, {
"hash" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4215",
"triggerID" : "73c191e3077bba3681cf47fd29d14245e38082b5",
"triggerType" : "PUSH"
}, {
"hash" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254",
"triggerID" : "b2adffed86531ab0eda2bc6ca89b346228829e42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2adffed86531ab0eda2bc6ca89b346228829e42 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org