You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/11/22 07:19:57 UTC
[GitHub] incubator-zeppelin pull request: Fix notebook clone bug
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/458
Fix notebook clone bug
Handle exception when paragraph's `getReturn` method returns unparseable object.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin fix/clone
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #458
----
commit 7ef6018fa43c11fc3005fa5e315fda9b71f37fae
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-11-22T06:09:53Z
Fix notebook clone bug when returns String Object
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix notebook clone bug
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/458#issuecomment-158736103
Looks great, but how complicated is it to reproduce this bug?
If there is a simple case, it might be worth adding a test too.
Also a bit of explanation in comments in case of empty catch block (i.e why is it ok to ignore it here) is of a [good style](https://google.github.io/styleguide/javaguide.html#s6.2-caught-exceptions)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix notebook clone bug
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/458#issuecomment-168944508
Looks like build failed due to networking issue on downloading mvn dependencies. Should not be reproducible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---