You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/06 07:19:38 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38931: [SPARK-41001][CONNECT][TESTS][FOLLOWUP] `ChannelBuilderTests` should be skipped by `should_test_connect` flag

grundprinzip commented on code in PR #38931:
URL: https://github.com/apache/spark/pull/38931#discussion_r1040584436


##########
python/pyspark/testing/connectutils.py:
##########
@@ -97,6 +97,7 @@ def _session_sql(cls, query: str) -> "DataFrame":
         return DataFrame.withPlan(SQL(query), cls.connect)  # type: ignore
 
     if have_pandas:
+

Review Comment:
   Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org