You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by osma <gi...@git.apache.org> on 2016/01/15 09:09:44 UTC
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
GitHub user osma opened a pull request:
https://github.com/apache/jena/pull/122
JENA-1118: bringing back the SDB distribution
See https://issues.apache.org/jira/browse/JENA-1118
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/osma/jena jena-sdb-assembly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 286d81223d179620d93a1bc2cfc45fdbc755e5fa
Author: Osma Suominen <os...@apache.org>
Date: 2016-01-15T08:08:14Z
JENA-1118: bringing back the SDB distribution
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49832973
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
Sorry, I'm confused now. Which `dist/LICENSE` should this be? There is no `jena-sdb/dist` directory nowadays. There is `jena-fuseki1/dist` and `apache-jena-fuseki/dist` currently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171934539
Hmm, there are several LICENSE files in the Jena source tree which mention "code contributed by Plugged In Software". It appears that some of these have old pathnames referring to `com.hp.hpl.jena` packages which have since been renamed:
```
$ grep ExtendedHandler `find . -name LICENSE`
./LICENSE:src/main/java/org/apache/jena/rdf/arp/ExtendedHandler.java
./jena-sdb/dist/LICENSE:src/main/java/com/hp/hpl/jena/rdf/arp/ExtendedHandler.java
./jena-core/LICENSE:src/main/java/com/hp/hpl/jena/rdf/arp/ExtendedHandler.java
./jena-core/src/main/resources/META-INF/LICENSE:src/main/java/com/hp/hpl/jena/rdf/arp/ExtendedHandler.java
./jena-core/target/classes/META-INF/LICENSE:src/main/java/com/hp/hpl/jena/rdf/arp/ExtendedHandler.java
./apache-jena/LICENSE:src/main/java/org/apache/jena/rdf/arp/ExtendedHandler.java
```
As you can see above, this affects not only the jena-sdb/dist/LICENSE file but also jena-core and apache-jena.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171907428
This makes "jena-sdb....distribution" becomes a binary product of the release. No problem with that but we should do it formerly. When this is running and distributions in the snapshots maven repo, could you email dev@ with a message asking for a review of the binary and specifically the N&L. We have to do that at release - it seems to me to be easier to do the task now, rather than at release when it's busy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171906648
It works for me. Also, jena-fuseki1 seems to do the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49833480
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
The deleted `jena-sdb/dist` -- it must be in git somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171908145
Ah, hm. I didn't realize that. I was thinking that it should simply be possible to build this distribution, just like it is currently possible to build the SDB jar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171932669
I checked the original dist/{N,L} in git and it looks like no additions from the main binary distribution. Did you spot anything? I've had an all-to-brief look of assembly.xml and it looks like it excludes all JDBC so no issues there. As the main N&L have been updated since so copy apache-jena/{N,L} to jena-sdb/dist as a starting point.
When you email dev@, I'll check the snapshot build. (I'm not in a position to do a local build myself to make a "distribution" and check just at the moment.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171937845
Okay I copied the changes from apache-jena. It seems that the pathnames were already fixed in the `apache-jena/LICENSE` file so they are now fixed in `jena-sdb/dist/LICENSE` too, but there are still stale copies around elsewhere, as evidenced by the above grep results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171906518
From memory, there were problems making an assembly and the jar in the same module. Some sort of name clash but maybe it wasn't this module and maybe that is why the assembly is "-distribution".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49831471
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
They are probably different. The `dist/` version cover everything in the assembly, including shipped dependencies. The ones at the top of the module just cover the code in the module.
Can we just pull `dist/` out of git and check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49832744
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
I changed this because the Maven assembler complained that "dist/LICENSE" didn't exist. I understood these paths to be relative to the jena-sdb directory.
Maybe change to "../dist/LICENSE"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49833662
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
Removed in ec123a3637c8bf115896d5fb2babc41c8eddbf6a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171911609
Official downloads is definitely another step. I think that is definitely a project-wide decision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171909369
Yes, it should "just work" and it does push it to maven.
See http://central.maven.org/maven2/org/apache/jena/jena-sdb/1.4.1/ which is the last one produced.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on a diff in the pull request:
https://github.com/apache/jena/pull/122#discussion_r49833529
--- Diff: jena-sdb/assembly.xml ---
@@ -41,11 +41,11 @@
<files>
<file>
- <source>dist/LICENSE</source>
+ <source>LICENSE</source>
--- End diff --
Ah, now I see. I'll hunt for it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171940432
I will merge this soon to master unless someone opposes...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171910727
Ah, okay. So these were actually produced for a while after the 1.3.6 release, but not put on the download site, just available via Maven Central. Okay, I think getting back to that state of affairs would be fine. I'm unsure about "official" downloads, knowing the state of SDB support available from the project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1118: bringing back the SDB distribution
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/122#issuecomment-171930883
I found and updated (year) LICENSE and NOTICE from git history. Good now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---