You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/13 09:25:24 UTC

[GitHub] [arrow] mr-smidge commented on pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

mr-smidge commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-657438635


   > In general, DateTimeOffset is the preferred type to use when talking about dates and times. The reasoning is because exactly what you point out in the JIRA issue - DateTime.Kind is very confusing and can cause a lot of problems.
   
   I suspect this is a matter of codebase/team preference.  By contract, my organisation previously recommended `DateTime` for dates.  I say "previously" because now we would use NodaTime's `LocalDate` instead :-).
   
   Nonetheless, in the absence of a proper type just for dates, I can see arguments for either, and I'll modify the API accordingly to accept both in a non-breaking manner.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org