[jira] [Commented] (HADOOP-7704) JsonFactory can be created only once and used for every next request to create JsonGenerator inside JMXJsonServlet

["Devaraj K (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120767#comment-13120767 ] 

Devaraj K commented on HADOOP-7704:
-----------------------------------

It doesn't need any tests because the changes are strightforward.
                
> JsonFactory can be created only once and used for every next request to create JsonGenerator inside JMXJsonServlet 
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7704
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7704
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.24.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7704.patch, MAPREDUCE-3129.patch
>
>
> 1. Currently JMXJsonServlet creates JsonFactory for every http request.
> Its not efficient. 
> JsonFactory can be created only once and used for every next request to create JsonGenerator.
> 2. Also following null check is not required.
> {code}
>  if (mBeanServer == null) {
>         jg.writeStringField("result", "ERROR");
>         jg.writeStringField("message", "No MBeanServer could be found");
>         jg.close();
>         LOG.error("No MBeanServer could be found.");
>         response.setStatus(HttpServletResponse.SC_NOT_FOUND);
>         return;
>  }
> {code}
> Because ManagementFactory.getPlatformMBeanServer(); will not return null.
> 3. Move the following code to finally so that any exception should not cause skipping of close method on JsonGenerator
> {code}
> jg.close();
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira