You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Trygve Laugstøl <tr...@apache.org> on 2007/02/15 08:36:03 UTC

Re: svn commit: r506479 - in /maven/continuum/trunk: continuum-api/src/main/java/org/apache/maven/continuum/ continuum-api/src/main/java/org/apache/maven/continuum/store/ continuum-core/src/main/java/org/apache/maven/continuum/ continuum-core/src/test/java...

evenisse@apache.org wrote:
> Author: evenisse
> Date: Mon Feb 12 07:19:35 2007
> New Revision: 506479
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=506479
> Log:
> Fix some jdo calls for performance improvment
> 
> Modified:
>     maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java
>     maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/store/ContinuumStore.java
>     maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
>     maven/continuum/trunk/continuum-core/src/test/java/org/apache/maven/continuum/DefaultContinuumTest.java
>     maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java
>     maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>     maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java
>     maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/component/BuildDefinitionSummaryAction.java
>     maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/component/NotifierSummaryAction.java
> 
> Modified: maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java
> URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java?view=diff&rev=506479&r1=506478&r2=506479
> ==============================================================================
> --- maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java (original)
> +++ maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java Mon Feb 12 07:19:35 2007
> @@ -80,6 +80,9 @@
>      public ProjectGroup getProjectGroupWithProjects( int projectGroupId )
>          throws ContinuumException;
>  
> +    public ProjectGroup getProjectGroupWithBuildDetails( int projectGroupId )
> +        throws ContinuumException;

Can we call this getProjectGroupWithBuildDetailsByProjectGroupId(..) to 
make it consistent?

>      public ProjectGroup getProjectGroupByGroupId( String groupId )
>          throws ContinuumException;
>  
> @@ -115,7 +118,11 @@
>  
>      BuildResult getLatestBuildResultForProject( int projectId );
>  
> +    Map getLatestBuildResults( int projectGroupId );

ditto here,

>      Map getLatestBuildResults();
> +
> +    Map getBuildResultsInSuccess( int projectGroupId );

and here.

>      Map getBuildResultsInSuccess();

[snip]

--
Trygve


Re: svn commit: r506479 - in /maven/continuum/trunk: continuum-api/src/main/java/org/apache/maven/continuum/ continuum-api/src/main/java/org/apache/maven/continuum/store/ continuum-core/src/main/java/org/apache/maven/continuum/ continuum-core/src/test/java...

Posted by Emmanuel Venisse <em...@venisse.net>.
Done.

Trygve Laugstøl a écrit :
> evenisse@apache.org wrote:
>> Author: evenisse
>> Date: Mon Feb 12 07:19:35 2007
>> New Revision: 506479
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=506479
>> Log:
>> Fix some jdo calls for performance improvment
>>
>> Modified:
>>     
>> maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java 
>>
>>     
>> maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/store/ContinuumStore.java 
>>
>>     
>> maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java 
>>
>>     
>> maven/continuum/trunk/continuum-core/src/test/java/org/apache/maven/continuum/DefaultContinuumTest.java 
>>
>>     
>> maven/continuum/trunk/continuum-store/src/main/java/org/apache/maven/continuum/store/JdoContinuumStore.java 
>>
>>     
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java 
>>
>>     
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java 
>>
>>     
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/component/BuildDefinitionSummaryAction.java 
>>
>>     
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/component/NotifierSummaryAction.java 
>>
>>
>> Modified: 
>> maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java?view=diff&rev=506479&r1=506478&r2=506479 
>>
>> ============================================================================== 
>>
>> --- 
>> maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java 
>> (original)
>> +++ 
>> maven/continuum/trunk/continuum-api/src/main/java/org/apache/maven/continuum/Continuum.java 
>> Mon Feb 12 07:19:35 2007
>> @@ -80,6 +80,9 @@
>>      public ProjectGroup getProjectGroupWithProjects( int 
>> projectGroupId )
>>          throws ContinuumException;
>>  
>> +    public ProjectGroup getProjectGroupWithBuildDetails( int 
>> projectGroupId )
>> +        throws ContinuumException;
> 
> Can we call this getProjectGroupWithBuildDetailsByProjectGroupId(..) to 
> make it consistent?
> 
>>      public ProjectGroup getProjectGroupByGroupId( String groupId )
>>          throws ContinuumException;
>>  
>> @@ -115,7 +118,11 @@
>>  
>>      BuildResult getLatestBuildResultForProject( int projectId );
>>  
>> +    Map getLatestBuildResults( int projectGroupId );
> 
> ditto here,
> 
>>      Map getLatestBuildResults();
>> +
>> +    Map getBuildResultsInSuccess( int projectGroupId );
> 
> and here.
> 
>>      Map getBuildResultsInSuccess();
> 
> [snip]
> 
> -- 
> Trygve
> 
> 
> 
>