[PR] Use semantic type equality in AddColumn [arrow-go]

["fallintoplace (via GitHub)" <gi...@apache.org>]

fallintoplace opened a new pull request, #878:
URL: https://github.com/apache/arrow-go/pull/878

   ### What changed
   
   simpleTable.AddColumn now compares the new field type and column type with arrow.TypeEqual instead of direct interface inequality.
   
   ### Why
   
   Many Arrow data types are structurally equal even when they are not the same pointer. The previous check could reject valid columns, while nearby table and column constructors already use semantic type equality.
   
   ### Validation
   
   - go test ./arrow/array -run 'TestTableAddColumnWithEqualDataType' -count=1
   - go test ./arrow/array -count=1
   - PARQUET_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/parquet-testing/data ARROW_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/arrow-testing/data go test ./... -count=1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use semantic type equality in AddColumn [arrow-go]

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade merged PR #878:
URL: https://github.com/apache/arrow-go/pull/878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org