You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/24 04:37:02 UTC

[kudu-CR] java: incorporate feedback from commit 37e53bf1d 

Hello Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13423

to review the following change.


Change subject: java: incorporate feedback from commit 37e53bf1d
......................................................................

java: incorporate feedback from commit 37e53bf1d

Change-Id: I066bbbb19f11fef892bcef47907acb946688f30b
---
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/13423/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I066bbbb19f11fef892bcef47907acb946688f30b
Gerrit-Change-Number: 13423
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] java: incorporate feedback from commit 37e53bf1d

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13423 )

Change subject: java: incorporate feedback from commit 37e53bf1d
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066bbbb19f11fef892bcef47907acb946688f30b
Gerrit-Change-Number: 13423
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 16:43:22 +0000
Gerrit-HasComments: No

[kudu-CR] java: incorporate feedback from commit 37e53bf1d

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13423 )

Change subject: java: incorporate feedback from commit 37e53bf1d
......................................................................

java: incorporate feedback from commit 37e53bf1d

Change-Id: I066bbbb19f11fef892bcef47907acb946688f30b
Reviewed-on: http://gerrit.cloudera.org:8080/13423
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I066bbbb19f11fef892bcef47907acb946688f30b
Gerrit-Change-Number: 13423
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)