[jira] [Commented] (HBASE-29326) Do not prevent prefetch from running if the given file has already been fully cached before

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-29326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954828#comment-17954828 ] 

Hudson commented on HBASE-29326:
--------------------------------

Results for branch branch-3
	[build #421 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/General_20Nightly_20Build_20Report/]








(/) {color:green}+1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.4.0 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/421/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.1 {color}


> Do not prevent prefetch from running if the given file has already been fully cached before 
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-29326
>                 URL: https://issues.apache.org/jira/browse/HBASE-29326
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.6.3
>
>
> Since HBASE-28176, we were skipping prefetch on files that have been fully cached before (and where BucketCache persistent cache successfully recovered all data blocks in the event of restarts). The problem is that meta blocks would be skipped too, and would only make into cache upon client reads, which could be costly when using cloud storage. In the prefetch logic, we already try to read each block from the cache first and skip file reading if we find the block already present in the cache. That would cause minimal impacts for running prefetch again on recovered bucket caches, as only meta blocks would indeed require cloud storage access.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)