You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/10 10:57:14 UTC

[GitHub] [logging-log4j2] ryancastle commented on a change in pull request #608: Restrict LDAP access via JNDI

ryancastle commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r766585720



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/JmsAppender.java
##########
@@ -100,8 +109,21 @@ public JmsAppender build() {
             JmsManager actualJmsManager = jmsManager;
             JmsManagerConfiguration configuration = null;
             if (actualJmsManager == null) {
+                Properties additionalProperties = null;
+                if (allowedLdapClasses != null || allowedLdapHosts != null) {

Review comment:
       Should this reference `allowedJndiProtocols` as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org