You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by Raymond Augé <ra...@liferay.com.INVALID> on 2022/02/19 17:52:55 UTC

maybe small bug in johnzon-maven-plugin test?

Hey folks,

This test resource [1] looks broken. Is it not?

Ray

[1]
https://github.com/apache/johnzon/blob/master/johnzon-maven-plugin/src/test/resources/SomeValue.record.java#L58-L59

Re: maybe small bug in johnzon-maven-plugin test?

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Ah I see, good one!

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le sam. 19 févr. 2022 à 19:44, Raymond Augé
<ra...@liferay.com.invalid> a écrit :

> Is this a valid Java (record) contruct?
>
> public static record SecondaryMetrics(
> }
>
> Should it be:
> public static record SecondaryMetrics() {
> }
>
> note I already have fixes coming for this generated construction.
>
> Ray
>
> On Sat, Feb 19, 2022 at 1:23 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Hi
> >
> > Not sure, it is a resource used by tests so looks fine to me but maybe i
> > didnt get the actual bug.
> >
> > Le sam. 19 févr. 2022 à 18:53, Raymond Augé
> > <ra...@liferay.com.invalid> a écrit :
> >
> > > Hey folks,
> > >
> > > This test resource [1] looks broken. Is it not?
> > >
> > > Ray
> > >
> > > [1]
> > >
> > >
> >
> https://github.com/apache/johnzon/blob/master/johnzon-maven-plugin/src/test/resources/SomeValue.record.java#L58-L59
> > >
> >
>
>
> --
> *Raymond Augé* (@rotty3000)
> Senior Software Architect *Liferay, Inc.* (@Liferay)
> OSGi Fellow, Java Champion
>

Re: maybe small bug in johnzon-maven-plugin test?

Posted by Raymond Augé <ra...@liferay.com.INVALID>.
Is this a valid Java (record) contruct?

public static record SecondaryMetrics(
}

Should it be:
public static record SecondaryMetrics() {
}

note I already have fixes coming for this generated construction.

Ray

On Sat, Feb 19, 2022 at 1:23 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Hi
>
> Not sure, it is a resource used by tests so looks fine to me but maybe i
> didnt get the actual bug.
>
> Le sam. 19 févr. 2022 à 18:53, Raymond Augé
> <ra...@liferay.com.invalid> a écrit :
>
> > Hey folks,
> >
> > This test resource [1] looks broken. Is it not?
> >
> > Ray
> >
> > [1]
> >
> >
> https://github.com/apache/johnzon/blob/master/johnzon-maven-plugin/src/test/resources/SomeValue.record.java#L58-L59
> >
>


-- 
*Raymond Augé* (@rotty3000)
Senior Software Architect *Liferay, Inc.* (@Liferay)
OSGi Fellow, Java Champion

Re: maybe small bug in johnzon-maven-plugin test?

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi

Not sure, it is a resource used by tests so looks fine to me but maybe i
didnt get the actual bug.

Le sam. 19 févr. 2022 à 18:53, Raymond Augé
<ra...@liferay.com.invalid> a écrit :

> Hey folks,
>
> This test resource [1] looks broken. Is it not?
>
> Ray
>
> [1]
>
> https://github.com/apache/johnzon/blob/master/johnzon-maven-plugin/src/test/resources/SomeValue.record.java#L58-L59
>