You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/01/11 14:59:46 UTC
[GitHub] [submarine] KUAN-HSUN-LI opened a new pull request #864: SUBMARINE-1173. Transfer description.json to config.pbtxt via protobuf API
KUAN-HSUN-LI opened a new pull request #864:
URL: https://github.com/apache/submarine/pull/864
### What is this PR for?
Serving a Pytorch model requires the `config,pbtxt` file which is generated by the protobuf. (reference: https://github.com/triton-inference-server/server/blob/main/docs/model_configuration.md)
Copy the model_config.proto to submarine and generate the API. With this API, we can transfer our description file into its format.
### What type of PR is it?
[Feature]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1173
### How should this be tested?
The test will be covered by the e2e test which will be provided in another PR.
### Screenshots (if appropriate)
https://user-images.githubusercontent.com/38066413/148966412-0afcef60-94c0-40e4-8dd5-9ff81c82dfc0.mp4
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #864: SUBMARINE-1173. Transfer description.json to config.pbtxt via protobuf API
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #864:
URL: https://github.com/apache/submarine/pull/864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI edited a comment on pull request #864: SUBMARINE-1173. Transfer description.json to config.pbtxt via protobuf API
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI edited a comment on pull request #864:
URL: https://github.com/apache/submarine/pull/864#issuecomment-1010051531
@pingsutw @jeff-901 Help me review the PR. Thanks!
I have disabled the `check style` for the generated file and I am not sure if the Licence in the `model-config.proto` file is appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on pull request #864: SUBMARINE-1173. Transfer description.json to config.pbtxt via protobuf API
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on pull request #864:
URL: https://github.com/apache/submarine/pull/864#issuecomment-1010051531
@pingsutw @jeff-901 Help me review the PR. Thanks!
I have disabled the `check style` in the generated file and I am not sure that is the Licence in the `model-config.proto` file is appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org