You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by jsievers <gi...@git.apache.org> on 2015/04/17 15:31:31 UTC
[GitHub] maven-wagon pull request: [WAGON-432] make sure User-Agent header ...
GitHub user jsievers opened a pull request:
https://github.com/apache/maven-wagon/pull/19
[WAGON-432] make sure User-Agent header is sent exactly once
- remove unnecessary explicit default User-Agent (all 3 HTTP wagon
providers [http, lightweight, webdav] send a User-Agent by default
already)
- when adding headers, use setHeader() instead of addHeader().
this will avoid sending the same header key multiple times
- adapt header listener in tests so it will detect header keys
sent multiple times
- add tests to make sure default User-Agent is always present and
User-Agent is present only once even if set multiple times
using different methods
Signed-off-by: Jan Sievers <ja...@sap.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsievers/maven-wagon master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit fadfcd9af264429674457b7696550c59c5059c5c
Author: Jan Sievers <ja...@sap.com>
Date: 2015-04-17T12:31:46Z
[WAGON-432] make sure User-Agent header is sent exactly once
- remove unnecessary explicit default User-Agent (all 3 HTTP wagon
providers [http, lightweight, webdav] send a User-Agent by default
already)
- when adding headers, use setHeader() instead of addHeader().
this will avoid sending the same header key multiple times
- adapt header listener in tests so it will detect header keys
sent multiple times
- add tests to make sure default User-Agent is always present and
User-Agent is present only once even if set multiple times
using different methods
Signed-off-by: Jan Sievers <ja...@sap.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon pull request: [WAGON-432] make sure User-Agent header ...
Posted by jsievers <gi...@git.apache.org>.
Github user jsievers closed the pull request at:
https://github.com/apache/maven-wagon/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org