You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/25 04:10:14 UTC

[GitHub] [superset] john-bodley commented on issue #15378: Temporal columns et al. are not adhered to when re-syncing column metadata

john-bodley commented on issue #15378:
URL: https://github.com/apache/superset/issues/15378#issuecomment-868188313


   @villebro it seems like you may have contributed to the [external_metdata](https://github.com/apache/superset/blob/822eb2e27e83238e2cd05a371b1d835f593d2907/superset/connectors/sqla/models.py#L650-L716) method. The problem is the `alter_new_orm_column` method which provides overrides (and which per the name suggests only gets called on table creation) doesn't seem to get called. More specifically it seems the add/update logic is completely different and thus could likely lead to inconsistencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org