You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fj...@apache.org on 2019/07/03 18:53:49 UTC
[incubator-druid] branch master updated: CONTRIBUTING: Remove "keep
the number of commits small" guidance. (#8004)
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 685aeac CONTRIBUTING: Remove "keep the number of commits small" guidance. (#8004)
685aeac is described below
commit 685aeac8eb8af389900e28cc708282499f8cf2c3
Author: Gian Merlino <gi...@gmail.com>
AuthorDate: Wed Jul 3 11:53:41 2019 -0700
CONTRIBUTING: Remove "keep the number of commits small" guidance. (#8004)
It is no longer really relevant in the world we have of committing
via merge-and-squash.
---
CONTRIBUTING.md | 4 ----
1 file changed, 4 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 38d2052..3a5c285 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -36,10 +36,6 @@ When submitting a pull request (PR), please use the following guidelines:
- Do not use author tags/information in the code.
- Try to keep pull requests short and submit separate ones for unrelated
features, but feel free to combine simple bugfixes/tests into one pull request.
-- Keep the number of commits small and combine commits for related changes.
- Each commit should compile on its own and ideally pass tests.
-- Keep formatting changes in separate commits to make code reviews easier and
- distinguish them from actual code changes.
You can find more developers' resources in [`dev/`](dev) directory.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org