[superset] branch master updated: fix(webdriver): default WEBDRIVER_OPTION_ARGS and update Firefox deps (#23388)

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e3a7d2014d fix(webdriver): default WEBDRIVER_OPTION_ARGS and update Firefox deps (#23388)
e3a7d2014d is described below

commit e3a7d2014df179088e14a5fc953dc66f69ba0f04
Author: ʈᵃᵢ <td...@gmail.com>
AuthorDate: Thu Mar 16 21:13:05 2023 -0700

    fix(webdriver): default WEBDRIVER_OPTION_ARGS and update Firefox deps (#23388)
---
 Dockerfile         | 9 ++++++++-
 superset/config.py | 5 ++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index b194471a31..f17675e117 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -114,7 +114,14 @@ COPY ./requirements/*.txt ./docker/requirements-*.txt/ /app/requirements/
 USER root
 
 RUN apt-get update -y \
-    && apt-get install -y --no-install-recommends libnss3 libdbus-glib-1-2 libgtk-3-0 libx11-xcb1 wget
+    && apt-get install -y --no-install-recommends \
+          libnss3 \
+          libdbus-glib-1-2 \
+          libgtk-3-0 \
+          libx11-xcb1 \
+          libasound2 \
+          libxtst6 \
+          wget
 
 # Install GeckoDriver WebDriver
 RUN wget https://github.com/mozilla/geckodriver/releases/download/${GECKODRIVER_VERSION}/geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz -O /tmp/geckodriver.tar.gz && \
diff --git a/superset/config.py b/superset/config.py
index 9643f30883..ec0ddb0ad7 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -1302,9 +1302,8 @@ WEBDRIVER_AUTH_FUNC = None
 WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {"service_log_path": "/dev/null"}
 
 # Additional args to be passed as arguments to the config object
-# Note: these options are Chrome-specific. For FF, these should
-# only include the "--headless" arg
-WEBDRIVER_OPTION_ARGS = ["--headless", "--marionette"]
+# Note: If using Chrome, you'll want to add the "--marionette" arg.
+WEBDRIVER_OPTION_ARGS = ["--headless"]
 
 # The base URL to query for accessing the user interface
 WEBDRIVER_BASEURL = "http://0.0.0.0:8080/"