You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org> on 2017/11/14 21:58:00 UTC

[jira] [Created] (CALCITE-2051) Rules using Aggregate might check for simple grouping sets incorrectly

Jesus Camacho Rodriguez created CALCITE-2051:
------------------------------------------------

             Summary: Rules using Aggregate might check for simple grouping sets incorrectly
                 Key: CALCITE-2051
                 URL: https://issues.apache.org/jira/browse/CALCITE-2051
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: Jesus Camacho Rodriguez
            Assignee: Jesus Camacho Rodriguez
            Priority: Critical
             Fix For: 1.15.0


CALCITE-1069 removed the indicator columns for Aggregate operators. In some places, the indicator boolean check was replaced by the following check: {{aggregate.getGroupSets().size() > 1}}. However, that check is incomplete, it should have been replace by {{aggregate.getGroupType() == Group.SIMPLE}}.

For instance : https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/rules/AggregateProjectMergeRule.java#L91




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)