You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "zhaorenhai (Jira)" <ji...@apache.org> on 2020/08/07 19:42:00 UTC
[jira] [Comment Edited] (IMPALA-10041) ./tests/run-tests.py
query_test/test_udfs.py failed on aarch64
[ https://issues.apache.org/jira/browse/IMPALA-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173008#comment-17173008 ]
zhaorenhai edited comment on IMPALA-10041 at 8/7/20, 7:41 PM:
--------------------------------------------------------------
The issue has been fixed
The code will be committed with IMPALA-10061
The following code resolve this issue:
diff --git a/be/src/codegen/llvm-codegen.cc b/be/src/codegen/llvm-codegen.cc
index da099f0cb..99ffb2f61 100644
— a/be/src/codegen/llvm-codegen.cc
+++ b/be/src/codegen/llvm-codegen.cc
@@ -892,7 +892,12 @@ Status LlvmCodeGen::LoadFunction(const TFunction& fn, const string& symbol,
// declaration, not a definition, since we do not create any basic blocks or
// instructions in it.
*llvm_fn = prototype.GeneratePrototype(nullptr, nullptr);
-
+#ifdef __aarch64__
+ if (is_decimal)
{ + // Mark first argument as sret + (*llvm_fn)->addAttribute(1, llvm::Attribute::StructRet); + }
+#endif
was (Author: renhaizhao):
The issue has been fixed
The code will be committed with IMPALA-9645
The following code resolve this issue:
diff --git a/be/src/codegen/llvm-codegen.cc b/be/src/codegen/llvm-codegen.cc
index da099f0cb..99ffb2f61 100644
--- a/be/src/codegen/llvm-codegen.cc
+++ b/be/src/codegen/llvm-codegen.cc
@@ -892,7 +892,12 @@ Status LlvmCodeGen::LoadFunction(const TFunction& fn, const string& symbol,
// declaration, not a definition, since we do not create any basic blocks or
// instructions in it.
*llvm_fn = prototype.GeneratePrototype(nullptr, nullptr);
-
+#ifdef __aarch64__
+ if (is_decimal) {
+ // Mark first argument as sret
+ (*llvm_fn)->addAttribute(1, llvm::Attribute::StructRet);
+ }
+#endif
> ./tests/run-tests.py query_test/test_udfs.py failed on aarch64
> --------------------------------------------------------------
>
> Key: IMPALA-10041
> URL: https://issues.apache.org/jira/browse/IMPALA-10041
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: huangtianhua
> Assignee: zhaorenhai
> Priority: Major
>
> ./tests/run-tests.py query_test/test_udfs.py failed on aarch64, and after running the test I can't connect to service port (21000) with impala-shell, here is the hs_err* log see details http://paste.openstack.org/show/796527/:
> Event: 1267.413 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(f547375fc3090862:d5eb2a1100000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1267.414 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(f547375fc3090862:d5eb2a1100000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1267.415 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(f547375fc3090862:d5eb2a1100000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1268.464 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(104a83b05eadaf75:3997ac4600000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1268.465 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(104a83b05eadaf75:3997ac4600000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1268.466 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(104a83b05eadaf75:3997ac4600000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1271.202 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(a24b33210572c6fe:e088eaaa00000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1271.203 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(a24b33210572c6fe:e088eaaa00000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1271.204 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(a24b33210572c6fe:e088eaaa00000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1272.064 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(89409c6895fe7b4f:2dc8521000000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1272.065 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(89409c6895fe7b4f:2dc8521000000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
> Event: 1272.066 Thread 0x0000000013a31800 Exception <a 'org/apache/impala/common/InternalException': Memory limit exceeded: FunctionContext::TrackAllocation's allocations exceeded memory limits.
> Query(89409c6895fe7b4f:2dc8521000000000) could not allocate 10.00 MB without exceeding limit.
> Error oc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org