You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jcsherin (via GitHub)" <gi...@apache.org> on 2024/07/26 13:56:36 UTC
[I] Use `AccumulatorArgs::is_reversed` in `NthValueAgg` [datafusion]
jcsherin opened a new issue, #11668:
URL: https://github.com/apache/datafusion/issues/11668
### Is your feature request related to a problem or challenge?
The changes in #11564 introduced `AccumulatorArgs::is_reversed`. This indicates that the sort order of the aggregation is reversed.
The existing implementation of `NthValueAgg` tracks this as internal state. Instead of that use `AccumulatorArgs::is_reversed`.
### Describe the solution you'd like
Refactor `NthValueAgg` to use `AccumulatorArgs::is_reversed`.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Use `AccumulatorArgs::is_reversed` in `NthValueAgg` [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #11668: Use `AccumulatorArgs::is_reversed` in `NthValueAgg`
URL: https://github.com/apache/datafusion/issues/11668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org