You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/11/18 22:31:49 UTC
[PR] Fix sorting in TR translation [airflow]
jscheffl opened a new pull request, #58460:
URL: https://github.com/apache/airflow/pull/58460
^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3549957695
> Yeah also thought about this... maybe just calling eslint after adding keys? (If you can not win over your enemy just take it in your arms :-D)
Yeah Good idea.
> Wondering though that this did not yell at static checks on the PR where this was merged though. Or also prek when adding changes locally...
Hmm. That makes me think something that @amoghrajesh I think thought about - turning the "check_translation_completness" script into a litle bit more complete breeze command that will simply run `prek eslint` after generating the translations?
`breeze ui check-translation-completness` (and also moving compile-ui-assets to `ui`) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3551953114
Yes, thanks @amoghrajesh I would love to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3550992136
@potiuk yeah I hear you, I think its a good idea to call eslint after we generate the translations to format is as we want after the changes are made. Let's do it. We can create an issue for it and someone could pick it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3551949608
cc @sunank200 since you expressed interest in breeze development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3549876443
> Hmm.. We need to finally fix the sorting by the "check_translation_Completness" -> I tried 2 times already - but I think there is a difference how the jslint sorting works with `name` vs `nameWithSomething`
Yeah also thought about this... maybe just calling eslint after adding keys? (If you can not win over your enemy just take it in your arms :-D)
Wondering though that this did not yell at static checks on the PR where this was merged though. Or also prek when adding changes locally...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3549813640
Hmm.. We need to finally fix the sorting by the "check_translation_Completness" -> I tried 2 times already - but I think there is a difference how the jslint sorting works with `name` vs `nameWithSomething`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58460:
URL: https://github.com/apache/airflow/pull/58460#issuecomment-3549814710
Or smth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix sorting in TR translation [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #58460:
URL: https://github.com/apache/airflow/pull/58460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org