[GitHub] [beam] Abacn commented on a diff in pull request #22233: Trying out property-based tests for Beam python coders

[GitBox <gi...@apache.org>]

Abacn commented on code in PR #22233:
URL: https://github.com/apache/beam/pull/22233#discussion_r961646234


##########
sdks/python/apache_beam/coders/row_coder.py:
##########
@@ -150,7 +150,9 @@ def _coder_from_type(field_type):
 def _nonnull_coder_from_type(field_type):
   type_info = field_type.WhichOneof("type_info")
   if type_info == "atomic_type":
-    if field_type.atomic_type in (schema_pb2.INT32, schema_pb2.INT64):
+    if field_type.atomic_type in (schema_pb2.INT16,

Review Comment:
   From #19815 INT16 was encoded in BigEndianShortCoder in Java side but just not implemented in other SDKs. This may cause data corruption. The "Encountered a type that is not currently supported by RowCoder" Exception is currently correctly raised.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org