You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/31 13:00:40 UTC
[GitHub] [rocketmq-clients] leizhiyuan opened a new pull request, #235: feat: Make each 'Client' have an independent 'ClientManager'
leizhiyuan opened a new pull request, #235:
URL: https://github.com/apache/rocketmq-clients/pull/235
issue: #179
Make each 'Client' have an independent 'ClientManager'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1247508922
@guyinyou PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] github-actions[bot] closed pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
URL: https://github.com/apache/rocketmq-clients/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] guyinyou commented on a diff in pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
guyinyou commented on code in PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#discussion_r971487631
##########
golang/client_manager.go:
##########
@@ -90,13 +90,14 @@ type ClientManagerRegistry interface {
}
type clientManagerRegistry struct {
- clientIds map[string]bool
- clientIdsLock sync.Mutex
- singletonClientManager ClientManager
+ clientIds map[string]bool
Review Comment:
After this pr, "clientIds" is useless, recommended to delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] github-actions[bot] commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1284735157
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1371824921
Thanks @leizhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1246164086
# [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#235](https://codecov.io/gh/apache/rocketmq-clients/pull/235?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c83bff) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/f0fc8e15415873e908275dbeaf0706ee32d0f86b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0fc8e1) will **decrease** coverage by `0.19%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #235 +/- ##
============================================
- Coverage 35.84% 35.64% -0.20%
Complexity 662 662
============================================
Files 220 220
Lines 11229 11227 -2
Branches 275 275
============================================
- Hits 4025 4002 -23
- Misses 6957 6977 +20
- Partials 247 248 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| golang | `36.91% <100.00%> (-0.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [golang/client\_manager.go](https://codecov.io/gh/apache/rocketmq-clients/pull/235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29sYW5nL2NsaWVudF9tYW5hZ2VyLmdv) | `65.11% <100.00%> (-8.62%)` | :arrow_down: |
| [golang/message\_id\_codec.go](https://codecov.io/gh/apache/rocketmq-clients/pull/235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29sYW5nL21lc3NhZ2VfaWRfY29kZWMuZ28=) | `55.55% <0.00%> (-5.56%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#discussion_r1059641303
##########
golang/client_manager.go:
##########
@@ -90,13 +90,14 @@ type ClientManagerRegistry interface {
}
type clientManagerRegistry struct {
Review Comment:
Could we remove `clientManagerRegistry`, since each `client` has its own `clientManager`, there is no need to maintain a "registry".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1368214259
@leizhiyuan Thanks for your attention! Sorry for not responding to this PR for a long time.
I am not familiar with Golang. IMHO, maybe we could construct a `ClientManager` directory if the singleton pattern is not applied in `ClientManager`, so the "registry" is seemingly redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#discussion_r1059641303
##########
golang/client_manager.go:
##########
@@ -90,13 +90,14 @@ type ClientManagerRegistry interface {
}
type clientManagerRegistry struct {
Review Comment:
Could we remove `clientManagerRegistry`, since each `client` has their own `clientManager`, it seems no need to maintain a "registry".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] leizhiyuan commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1284736795
？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] github-actions[bot] commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1279858940
This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org