You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2020/04/14 00:13:49 UTC
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15726
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
IMPALA-9650: Fix flakiness in RuntimeFilterTest
IMPALA-9612 adds RuntimeFilterTest to the set of backend tests. It
adds a delay injection code in runtime-filter.cc to reproduce the race
condition. However, the delay injection code will be stripped out when
Impala is build with release config. This patch remove the NDEBUG
macro enclosing the delay injection code so that it will not be
stripped out in release build.
Testing:
- Ran and pass pass backend tests against release build.
Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
---
M be/src/runtime/runtime-filter.cc
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/15726/1
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 00:19:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Build Failed
>
> https://jenkins.impala.io/job/gerrit-code-review-checks/5799/ : Initial code review checks failed. See linked job for details on the failure.
Seems like a failure in dependency download. Retry maybe?
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:19:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5799/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 00:52:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:24:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5650/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:24:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 21:41:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15726 )
Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest
......................................................................
IMPALA-9650: Fix flakiness in RuntimeFilterTest
IMPALA-9612 adds RuntimeFilterTest to the set of backend tests. It
adds a delay injection code in runtime-filter.cc to reproduce the race
condition. However, the delay injection code will be stripped out when
Impala is build with release config. This patch remove the NDEBUG
macro enclosing the delay injection code so that it will not be
stripped out in release build.
Testing:
- Ran and pass pass backend tests against release build.
Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Reviewed-on: http://gerrit.cloudera.org:8080/15726
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/runtime-filter.cc
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>